GNOME Bugzilla – Bug 567466
PNG comment not found if more than 1 tEXt chunks
Last modified: 2009-07-16 20:32:06 UTC
In a PNG image a comment (chunk of type "tEXt" with keyword "Comment") is not found in image properties, if the image contains more than one tEXt chunks with different keywords.
It looks like there is code in the PNG plug-in to handle this, though - http://svn.gnome.org/viewvc/gimp/branches/gimp-2-6/plug-ins/common/file-png.c?view=markup, line 1031ff.
Could you attach a sample image, please?
Created attachment 126489 [details] Sample images for bug demonstration
If a work on this bug is done it would be nice to complete it with evaluation of all keywords in http://www.w3.org/TR/PNG/#11keywords and user supplied keywords to. All read keywords should be written too, else a fully metainfo tagged image is destroyed after editing, because metainfo is important. A change in the edit box should be stored always, not only via "Save as".
Maybe you want to try this? Shouldn't be too complex to add this to the PNG plug-in.
Created attachment 138452 [details] [review] proposed patch This one is an oversight: only the first tEXt chunk of a png is considered, though repeatedly, when looking for the Comment. Patch against file 'plug-ins/common/file-png.c' of the release 2.6.6.
Is there anything we can do to help you switch to git?
IMO we should apply this fix to 2.6 as well. Supporting all keywords is a job for the meta-data plug-in and should be handled in a new report (preferably by adding patches at the same time as opening it :), but we might want to discuss this on gimp-developer first.
commit 65c21b6bc3eb1455cbd7f890b568d3504f7250f4 Author: Massimo Valentini <sixtysix@inwind.it> Date: Thu Jul 16 22:24:59 2009 +0200 Bug 567466 – PNG comment not found if more than 1 tEXt chunks Fix an oversight: only the first tEXt chunk of a PNG was considered, though repeatedly, when looking for the comment. plug-ins/common/file-png.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)