GNOME Bugzilla – Bug 567262
Black pixels appear in "Spread" filter preview
Last modified: 2009-07-08 19:26:38 UTC
Black pixels appears (In the small preview window), when I try to add some noise with the "Spread" filter. When I drug the scroll bar up and down, or left and right few times, the black pixels dissapears. If I will not drug the scroll bar up/down or left/right, And I will press "OK" That black pixels will be added to the picture. http://img101.imageshack.us/img101/4694/errored5.jpg Sorry for the poor English, Veacheslav
Russian windwos Xp SP3 Intel E2140 1.6 Ghz
I can't reproduce this. Please provide step by step instructions.
1.I selected some area on the picture; http://img515.imageshack.us/img515/3245/29043137ix9.jpg 2.I openned noise window; http://img519.imageshack.us/img519/4311/88790262ql5.jpg 3.I pressed "OK" http://img519.imageshack.us/img519/8890/40499402wd6.jpg And there is the frame of black pixel's in pic #3 Is this enough detailed?
This error appears in GIMP 2.6.3 and 2.6.4
One of your images did provide enough details - having a selection (that is smaller than the image) is important, otherwise it cannot be reproduced.
So when this bug will be fixed?
When someone fixes it.
Created attachment 137778 [details] [review] The proposed patch against the release 2.6.6
This plug-in makes use of a gimp_pixel_fetcher to access the source image. And a gimp_pixel_fetcher in its default state only returns pixels inside the bounding box of the selection. Setting its edge-mode to whatever but GIMP_PIXEL_FETCHER_EDGE_NONE, allows to read pixels outside of the selection. That's what the attached patch is supposed to do. This way the edges of the selected region are treated uniformly regardless of being on the bounding box or not. And no black pixels.
Perhaps a comment would be nice explaining why the edge-mode is set. And there's a space missing before the opening bracket. Massimo, would it be possible for you to start to use git? That would make it so much easier for all us.
Patch applied (with some minor coding style changes) to master and merged to the gimp-2-6 branch. Closing as FIXED. Massimo, thanks a lot for your help with this bug. commit 34ccca92a5cdb273ec93dd94c3a91d7920384646 Author: Massimo Valentini <sixtysix@inwind.it> Date: Tue Jul 7 17:07:12 2009 +0200 Bug 567262 – Black pixels appear in "Spread" filter preview The plug-in makes use of a GimpPixelFetcher to access the source image. And a GimpPixelFetcher in its default state only returns pixels inside the bounding box of the selection. Setting its edge-mode to whatever but GIMP_PIXEL_FETCHER_EDGE_NONE allows to read pixels outside of the selection. plug-ins/common/noise-spread.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)