GNOME Bugzilla – Bug 567254
Wrong icon for folder bookmarks
Last modified: 2009-04-27 16:35:02 UTC
+++ This bug was initially created as a clone of Bug #539286 +++ The bookmarks inside the places menu seem to be using the wrong icon when a theme like mist (themes inheriting the gnome theme) is used. In this case, bookmarks for special URIs like ssh:/// and obex:/// show the theme's folder icon while file:/// bookmarks only show the gnome folder. This is caused by a wrong fallback order of icons assigned to folders. Icon names like folder-drag-accept, folder-open, folder-visiting and text-x-preview should be prepended to the list of icon names, rather than appended. This way, the inode/directory being present in the theme doesn't override the aforementioned special icons.
Created attachment 126171 [details] [review] Icon fallback order patch This patch places appends icons like folder-drag-accept to the NautilusFile's icon rather than appending it, causing the correct behavior or treating the "inode-directory" icon as equivalent to "folder", and not as an override of all folder-* icons.
Created attachment 126173 [details] [review] Icon fallback order patch v2 Reworked patch that also makes "folder" override "inode-directory" to restore freedesktop.org icon naming compliance.
Krzysztof, Don't forget to send your patch to nautilus mailing-list
I just browsed the nautilus mailing list and saw the patch posted there. No one seems to have replied to the thread and I haven't seen any comments regarding the bug in the trunk revisions changelog, will we get to see a resolution for this issue before a future stable release?
*** Bug 571209 has been marked as a duplicate of this bug. ***
I am currently experiencing this issue in fully updated Fedora 10. When I click "Home" or "Documents" or whatever folder in the Places menu in Gnome, it opens with Easytag, rather than Nautilus. I was also experiencing the issue in Mandriva Cooker in Sept. 2008 (see https://qa.mandriva.com/show_bug.cgi?id=44350 ), but was able to at least semi-resolve it with the following: rm -rf /usr/share/icons/gnome/scalable/places/inode-directory.svg rm -rf /usr/share/icons/gnome/32x32/places/inode-directory.png rm -rf /usr/share/icons/gnome/24x24/places/inode-directory.png rm -rf /usr/share/icons/gnome/22x22/places/inode-directory.png rm -rf /usr/share/icons/gnome/16x16/places/inode-directory.png rm -rf /usr/share/icons/gnome/icon-theme.cache gtk-update-icon-cache -qf /usr/share/icons/gnome This has not worked for Fedora 10 though, sadly. :\
Thanks, committed to master. commit 48ed43f32668e5615ac64a3de55ec7ab2f254ef7 Author: Cosimo Cecchi <cosimoc@gnome.org> Date: Mon Apr 27 18:34:18 2009 +0200 Reverse the order for folder icons overrides Use the correct order for folder icons overrides, so that we can keep track of things like "folder-visiting" or "folder-drag-accept". Patch by Krzysztof Kosiński (#567254).