GNOME Bugzilla – Bug 567168
appsink is using the wrong signal slot for the pull-buffer signal.
Last modified: 2009-01-09 23:13:17 UTC
From the code: gst_app_sink_signals[SIGNAL_PULL_PREROLL] = g_signal_new ("pull-buffer", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION, G_STRUCT_OFFSET (GstAppSinkClass, pull_buffer), NULL, NULL, gst_app_marshal_OBJECT__VOID, GST_TYPE_BUFFER, 0, G_TYPE_NONE); Should be fixed before release. I am not entirely sure which of the two signals would not be working correctly because of this, btw - I assume pull-preroll.
So this is completely cosmetic as discussed on IRC, but please fix if you feel like it, since it's just a matter of changing the constant...
Committed, thanks! 2009-01-09 Jan Schmidt <jan.schmidt@sun.com> * gst-libs/gst/app/gstappsink.c: Store the returned signal id in the right slot when registering the pull-buffer signal. Fixes #567168 Spotted by: Thomas Vander Stichele <thomas at apestaart dot org>