After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567168 - appsink is using the wrong signal slot for the pull-buffer signal.
appsink is using the wrong signal slot for the pull-buffer signal.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-09 16:00 UTC by Thomas Vander Stichele
Modified: 2009-01-09 23:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Vander Stichele 2009-01-09 16:00:54 UTC 
From the code:

  gst_app_sink_signals[SIGNAL_PULL_PREROLL] =
      g_signal_new ("pull-buffer", G_TYPE_FROM_CLASS (klass),
      G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION, G_STRUCT_OFFSET (GstAppSinkClass,
          pull_buffer), NULL, NULL, gst_app_marshal_OBJECT__VOID,
      GST_TYPE_BUFFER, 0, G_TYPE_NONE);

Should be fixed before release.

I am not entirely sure which of the two signals would not be working correctly because of this, btw - I assume pull-preroll.
Comment 1 Jan Schmidt 2009-01-09 16:20:22 UTC 
So this is completely cosmetic as discussed on IRC, but please fix if you feel like it, since it's just a matter of changing the constant...
Comment 2 Jan Schmidt 2009-01-09 23:13:17 UTC 
Committed, thanks!

2009-01-09  Jan Schmidt  <jan.schmidt@sun.com>

        * gst-libs/gst/app/gstappsink.c:
        Store the returned signal id in the right slot when
        registering the pull-buffer signal.
        Fixes #567168
        Spotted by: Thomas Vander Stichele  <thomas at apestaart dot org>