After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567148 - icon in calendar preferences hard to understand
icon in calendar preferences hard to understand
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.24.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
evolution[compeditor]
: 259955 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-01-09 12:09 UTC by Andreas Nilsson
Modified: 2009-02-12 12:09 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
screenshot (17.21 KB, image/png)
2009-01-09 12:11 UTC, Andreas Nilsson
  Details
it also looks pretty slick when the entry and the button is the same size (16.86 KB, image/png)
2009-01-09 12:14 UTC, Andreas Nilsson
  Details
Proposed patch (1.19 KB, patch)
2009-01-09 13:51 UTC, Matthew Barnes
committed Details | Review

Description Andreas Nilsson 2009-01-09 12:09:51 UTC
I intended to change the time-zone today, but got a little confused by the preferences window. There was a entry and next to it was a big, blue blob. After staring at it for a while, I realized it was supposed to be a map with a pin next to it, so I clicked it.
Perhaps it would be a bit clearer if there was a text saying "Select..." instead of the icon. It eats up a couple of more pixels, but it's a lot easier to understand.

If I open the glade file calendar/gui/dialogs/cal-prefs-dialog.glade, it says the function is called make_timezone_entry, but I'm not sure how to create a patch.
Comment 1 Andreas Nilsson 2009-01-09 12:11:52 UTC
Created attachment 126100 [details]
screenshot
Comment 2 Andreas Nilsson 2009-01-09 12:14:10 UTC
Created attachment 126101 [details]
it also looks pretty slick when the entry and the button is the same size
Comment 3 Matthew Barnes 2009-01-09 13:51:30 UTC
Created attachment 126109 [details] [review]
Proposed patch

I like it better too.

This also changes the appointment editor.  Make sure View -> Time Zone is checked to see it.
Comment 4 Andreas Nilsson 2009-01-09 14:06:22 UTC
Matthew: you're always so quick! How do you do it? :)
Comment 5 Matthew Barnes 2009-01-09 14:08:21 UTC
Good way to procrastinate what I'm -really- supposed to be doing.  ;)
Comment 6 Srinivasa Ragavan 2009-01-12 04:13:02 UTC
To trunk
Comment 7 Suman Manjunath 2009-01-12 04:38:40 UTC
Patch committed to SVN trunk as r37051
http://svn.gnome.org/viewvc/evolution?view=revision&revision=37051
Comment 8 Matthew Barnes 2009-01-21 10:59:26 UTC
Closing as FIXED.
Comment 9 Matthew Barnes 2009-02-12 12:09:39 UTC
*** Bug 259955 has been marked as a duplicate of this bug. ***