After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567129 - evolution "Email Custom Header" dialog is not localized
evolution "Email Custom Header" dialog is not localized
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Plugins
unspecified
Other opensolaris
: Normal normal
: ---
Assigned To: evolution-plugin-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-01-09 07:55 UTC by Takao Fujiwara
Modified: 2009-03-22 18:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for email-custom-header/apps_evolution_email_custom_header.schemas.in, plugins/email-custom-header/email-custom-header.c (1.50 KB, patch)
2009-01-09 07:58 UTC, Takao Fujiwara 		accepted-commit_now Details | Review
Patch to revise patch #126086 (3.41 KB, patch)
2009-01-10 04:45 UTC, Takao Fujiwara 		none Details | Review

Description Takao Fujiwara 2009-01-09 07:55:01 UTC 
"Email Custom Header" dialog get the strings from apps_evolution_email_custom_header.schemas and the dialog is not localized because the .schemas file is not localized.

To reproduce:
1. Invoke evolution
2. Choose [File] -> [New] -> [Mail Message].
3. Choose [Insert] -> [Custom Header].

Then the "Security:" label and "Personal" pull down menu items are not localized.

I'm attaching the patch.
Comment 1 Takao Fujiwara 2009-01-09 07:58:13 UTC 
Created attachment 126086 [details] [review]
Patch for email-custom-header/apps_evolution_email_custom_header.schemas.in, plugins/email-custom-header/email-custom-header.c

The patch can extract translatable strings with 'intltool-update -p'.
Comment 2 Matthew Barnes 2009-01-09 12:45:31 UTC 
Interesting.  I didn't know you could put <default> under <locale>.

So long as it works, approved.
Comment 3 Takao Fujiwara 2009-01-09 15:33:42 UTC 
Thanks much for your review.

2009-01-09  Takao Fujiwara  <takao.fujiwara@sun.com>

        Reviewed by Matthew Barnes  <mbarnes@redhat.com>

        ** Fix for bug #567129

        * apps_evolution_email_custom_header.schemas.in:
        Add <default> tag in C locale to localize the value.
        * email-custom-header.c (epech_setup_widgets):
        Add gettext.
Comment 4 Takao Fujiwara 2009-01-10 04:45:04 UTC 
Created attachment 126157 [details] [review]
Patch to revise patch #126086

After I applied this patch, I noticed the mail header has the multibyte mail fields.
I'd like to i18n GUI only.

Could you review the revised patch?
Comment 5 André Klapper 2009-03-22 09:00:59 UTC 
Can the last patch get a review?
Comment 6 Takao Fujiwara 2009-03-22 18:52:33 UTC 
Yes, the revised patch was integrated with bug 567568.