After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567003 - [ladspa] improve plugin scanning
[ladspa] improve plugin scanning
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-08 09:42 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-03-04 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-01-08 09:42:45 UTC
we could update the plugin-scanning code a bit:
I have a copy of that in my buzzloader and have over time glib-ified it
(http://buzztard.svn.sourceforge.net/viewvc/buzztard/trunk/gst-buzztard/src/bml/plugin.c?revision=2194&view=markup)
it also makes sense to have it as static function in the gstladspa.c
and also add LIBDIR/ladspa to the path if we want to add some defaults.
Comment 1 Tim-Philipp Müller 2009-01-08 11:03:21 UTC
Sounds like a good idea to me - could you make a patch?
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-04 13:16:30 UTC
commit 5967670c8c0a9016ab84e7e140ddbb4dbe910dc4
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Wed Mar 4 15:05:48 2009 +0200

ladspa: add LIBDIR/ladspa to search path and make path more portable

Use glib defines for searchpath separators. Filter searchpath to avoid scanning
path entries twice. Fix the return in ladspa_plugin_directory_search to return
wheter we found a plugin.

commit 91abc9e97a6833a497e780651743ca4ba4d7fcf0
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Wed Mar 4 14:34:12 2009 +0200

ladspa: rewrite the directory scanning, fixes first part of #573370

Move the two function from search.c into gstladspa.c and make them static.
Remove non needed arguments from function prototypes. Use glib api for
simplicity and portability.