Created attachment 125982 [details] [review]
patch

Did you mean to include the qtmux part too?

Should video/x-dirac disappear from the sink pad template of mpegtsmux with this patch?

Didn't intend to, but it's essentially the same fix.

Yeah, video/x-dirac should disappear, assuming we wish to break working code that happens to create broken files.  (I do, but other people don't like breaking stuff as much as I do.)

Seems like the patch needs more work: The handling of video/x-dirac already disappeared in favour of mpegts-part, so it should disappear from the sink pad caps too, if that's the way things are going. Who converts video/x-dirac to video/x-mpegtspart? What parses an existing stream in the case of remuxing?

Also:
     ts_data->stream = tsmux_create_stream (mux->tsmux, TSMUX_ST_VIDEO_DIRAC,
         ts_data->pid);

Why is the constant still VIDEO_DIRAC, if the incoming caps are video/x-mpegtspart, which sounds like it is designed to carry multiple video formats?

The qtmuxmap part looks OK.

schroenc and schroparse create video/x-mpeg-ts-part.

Yeah, skip the mpegtsmux part of the patch.  I don't think it creates valid Dirac in MPEG-TS streams yet anyway, which isn't going to get fixed before the release.

If you just want to do the qtmux/mp4mux bits, go for it.

Done.