After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 566957 - Add time based seeking to ResinDVD
Add time based seeking to ResinDVD
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal blocker
: 0.10.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-07 23:19 UTC by Jan Schmidt
Modified: 2009-01-09 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support for time based seeks, and fix a bug in how segments are closed by the 'audio munger' (6.70 KB, patch)
2009-01-07 23:23 UTC, Jan Schmidt
none Details | Review
Add support for time based seeks, and fix a bug in how segments are closed by the 'audio munger' (6.70 KB, patch)
2009-01-07 23:23 UTC, Jan Schmidt
committed Details | Review
More patch (5.74 KB, patch)
2009-01-09 01:00 UTC, Jan Schmidt
none Details | Review
New, more better seeking patch (7.58 KB, patch)
2009-01-09 15:29 UTC, Jan Schmidt
committed Details | Review

Description Jan Schmidt 2009-01-07 23:19:39 UTC
Patch follows
Comment 1 Jan Schmidt 2009-01-07 23:23:08 UTC
Created attachment 125983 [details] [review]
Add support for time based seeks, and fix a bug in how segments are closed by the 'audio munger'

Since resindvd is in bad, I'd like to violate my own freeze and commit this before new pre-releases on Friday, if people are up for it.
Comment 2 Jan Schmidt 2009-01-07 23:23:16 UTC
Created attachment 125984 [details] [review]
Add support for time based seeks, and fix a bug in how segments are closed by the 'audio munger'

Since resindvd is in bad, I'd like to violate my own freeze and commit this before new pre-releases on Friday, if people are up for it.
Comment 3 Edward Hervey 2009-01-08 12:00:41 UTC
no objections from me.
Comment 4 Jan Schmidt 2009-01-08 12:42:57 UTC
Have only heard +1's, so committed:

2009-01-08  Jan Schmidt  <jan.schmidt@sun.com>

        * ext/resindvd/resindvdbin.c:
        * ext/resindvd/resindvdsrc.c:
        * ext/resindvd/resindvdsrc.h:
        * ext/resindvd/rsnaudiomunge.c:
        Add support for time based seeking.
        Make setting dvd:// reset to the default device.
        Make the 'audiomunge' element send any new segment start before
        the 'gap filler' buffer it generates, and any segment closes
        after.
        Fixes: #566957
Comment 5 Jan Schmidt 2009-01-09 01:00:42 UTC
Created attachment 126067 [details] [review]
More patch

In for a penny, in for a pound as they say. I realised that the patch yesterday only works when for the first PGC in a given VTS - ie, it tends to seek fine in long movies, and fail utterly in DVDs like TV shows, with multiple episodes in a single VTS.

Attached patch fixes, incidentally also fixing problems with the elementary stream layout descriptions passed downstream by getting the 'in_menu' flag correct.
Comment 6 Jan Schmidt 2009-01-09 15:29:10 UTC
Created attachment 126112 [details] [review]
New, more better seeking patch

Variation of the previous 'More patch' that fixes a) remembering that it's a flushing seek for TIME base seeks, because basesrc doesn't call prepare_seek for seeks already in the correct format b) Parsing the cell IFO time correctly. It only worked by accident for specific time entries before, because DVD stores the time in BCD yay.