GNOME Bugzilla – Bug 566957
Add time based seeking to ResinDVD
Last modified: 2009-01-09 16:52:45 UTC
Patch follows
Created attachment 125983 [details] [review] Add support for time based seeks, and fix a bug in how segments are closed by the 'audio munger' Since resindvd is in bad, I'd like to violate my own freeze and commit this before new pre-releases on Friday, if people are up for it.
Created attachment 125984 [details] [review] Add support for time based seeks, and fix a bug in how segments are closed by the 'audio munger' Since resindvd is in bad, I'd like to violate my own freeze and commit this before new pre-releases on Friday, if people are up for it.
no objections from me.
Have only heard +1's, so committed: 2009-01-08 Jan Schmidt <jan.schmidt@sun.com> * ext/resindvd/resindvdbin.c: * ext/resindvd/resindvdsrc.c: * ext/resindvd/resindvdsrc.h: * ext/resindvd/rsnaudiomunge.c: Add support for time based seeking. Make setting dvd:// reset to the default device. Make the 'audiomunge' element send any new segment start before the 'gap filler' buffer it generates, and any segment closes after. Fixes: #566957
Created attachment 126067 [details] [review] More patch In for a penny, in for a pound as they say. I realised that the patch yesterday only works when for the first PGC in a given VTS - ie, it tends to seek fine in long movies, and fail utterly in DVDs like TV shows, with multiple episodes in a single VTS. Attached patch fixes, incidentally also fixing problems with the elementary stream layout descriptions passed downstream by getting the 'in_menu' flag correct.
Created attachment 126112 [details] [review] New, more better seeking patch Variation of the previous 'More patch' that fixes a) remembering that it's a flushing seek for TIME base seeks, because basesrc doesn't call prepare_seek for seeks already in the correct format b) Parsing the cell IFO time correctly. It only worked by accident for specific time entries before, because DVD stores the time in BCD yay.