GNOME Bugzilla – Bug 566878
[ladspa] Add dependencies for ladspa modules
Last modified: 2009-01-24 22:02:19 UTC
Attached patch adds dependencies for the ladspa module directories
Created attachment 125910 [details] [review] ladspa-dependencies.diff
ladspa-dependencies.diff
Created attachment 125917 [details] [review] ladspa-dependencies.diff
>+ "LADSPA_PATH", In case ladspa also checks for plugins in the home directory, this could be expressed as e.g. "LADSPA_PATH,HOME/.ladspa" (I don't know if it does though, just thought I'd mention it). >+ "usr/lib/ladspa:/usr/local/lib/ladspa", Isn't there a leading slash missing here at the beginning?
Created attachment 125952 [details] [review] ladspa-dependencies.diff It doesn't look inside $HOME ;)
Created attachment 126010 [details] [review] use GST_PLUGIN_DEPENDENCY_FLAG_PATHS_ARE_DEFAULT_ONLY flag IMHO, Flags should be GST_PLUGIN_DEPENDENCY_FLAG_PATHS_ARE_DEFAULT_ONLY to not override the envvar.
2009-01-08 Sebastian Dröge <sebastian.droege@collabora.co.uk> * ext/ladspa/gstladspa.c: (plugin_init): Add plugin dependency for the LADSPA plugin directories. Fixes bug #566878.
I just saw this in the gst-plugins-bad-0.10.10 release notes. This will *not* work on systems which have lib64 instead of lib, such as most 64 bit Linux distros. Re-Open?
There's no regression there afaics - this patch adds a trigger to rescan the LADSPA plugin if any of the directories it scans changes - but it was scannning that (wrong) list of directories already. I think you're talking about a related but different bug - "Ladspa plugin won't work correctly on lib64 systems"
(In reply to comment #9) > There's no regression there afaics - this patch adds a trigger to rescan the > LADSPA plugin if any of the directories it scans changes - but it was scannning > that (wrong) list of directories already. > > I think you're talking about a related but different bug - "Ladspa plugin won't > work correctly on lib64 systems" > I'm not claiming that there is a regression, I've only looked at the patch and what is done there obviously will not work on 64 bit systems.