After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 566812 - gst_mixer_list_tracks() docs doesn't say whether members of GList should be freed
gst_mixer_list_tracks() docs doesn't say whether members of GList should be f...
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: documentation
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-06 20:17 UTC by José Alburquerque
Modified: 2009-01-09 17:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Patch to add comment about mixer list to gst_mixer_list_tracks() (1.19 KB, patch)
2009-01-07 18:07 UTC, José Alburquerque 		committed Details | Review

Description José Alburquerque 2009-01-06 20:17:31 UTC 
From looking at the code it looks like the members should not be freed, but I'd like to be sure so I filed this bug to make certain.
Comment 1 Sebastian Dröge (slomo) 2009-01-07 08:35:26 UTC 
The return type of gst_mixer_list_tracks() is a const GList, i.e. members and the list must not be freed ;)
Comment 2 José Alburquerque 2009-01-07 15:17:10 UTC 
Sorry.  I quickly compared the docs of gst_color_balance_list_channels() with gst_mixer_list_tracks() and didn't take note that the return is a const GList. :-)
Comment 3 José Alburquerque 2009-01-07 16:13:24 UTC 
(In reply to comment #2)
> Sorry.  I quickly compared the docs of gst_color_balance_list_channels() with
> gst_mixer_list_tracks() and didn't take note that the return is a const GList.
> :-)

What I mean to say is: shouldn't the docs be consistent, i.e. if you say it in one place maybe you should also say it in the other.
Comment 4 José Alburquerque 2009-01-07 18:07:08 UTC 
Created attachment 125950 [details] [review]
Patch to add comment about mixer list to gst_mixer_list_tracks()

In case you change your mind, I'm supplying the patch for your convenience.  I just copied the extra comment from GstColorBalance and edited it for GstMixer.  Again, keep up the good work.