GNOME Bugzilla – Bug 566812
gst_mixer_list_tracks() docs doesn't say whether members of GList should be freed
Last modified: 2009-01-09 17:17:35 UTC
From looking at the code it looks like the members should not be freed, but I'd like to be sure so I filed this bug to make certain.
The return type of gst_mixer_list_tracks() is a const GList, i.e. members and the list must not be freed ;)
Sorry. I quickly compared the docs of gst_color_balance_list_channels() with gst_mixer_list_tracks() and didn't take note that the return is a const GList. :-)
(In reply to comment #2) > Sorry. I quickly compared the docs of gst_color_balance_list_channels() with > gst_mixer_list_tracks() and didn't take note that the return is a const GList. > :-) What I mean to say is: shouldn't the docs be consistent, i.e. if you say it in one place maybe you should also say it in the other.
Created attachment 125950 [details] [review] Patch to add comment about mixer list to gst_mixer_list_tracks() In case you change your mind, I'm supplying the patch for your convenience. I just copied the extra comment from GstColorBalance and edited it for GstMixer. Again, keep up the good work.