Bug 566750 – [appsrc/sink] add padding, move private data to private struct, since markers

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 566750 - [appsrc/sink] add padding, move private data to private struct, since markers


Summary:	[appsrc/sink] add padding, move private data to private struct, since markers


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-base
Version:	0.10.22
Hardware:	Other Linux

Importance:	Normal blocker
Target Milestone:	0.10.22
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-01-06 10:07 UTC by Tim-Philipp Müller
Modified:	2009-01-06 11:14 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
patch adding padding, private struct and since markers (43.46 KB, patch) 2009-01-06 10:09 UTC, Tim-Philipp Müller	committed	Details \| Review

Description Tim-Philipp Müller 2009-01-06 10:07:39 UTC

- appsrc/sink is missing padding

 - appsrc/sink API is missing Since: 0.10.22 gtk-doc markers

 - if the private data in the instance struct is
   really private, it might be a good idea to move
   it all into a private instance struct

Comment 1 Tim-Philipp Müller 2009-01-06 10:09:29 UTC

Created attachment 125844 [details] [review]
patch adding padding, private struct and since markers

Also: do we really want/need to expose the debug categories in the public headers?

Comment 2 Jan Schmidt 2009-01-06 10:19:48 UTC

Hey Tim, you're awesome.

No, I don't see any reason the debug cats need to be available externally...

Comment 3 Tim-Philipp Müller 2009-01-06 11:14:05 UTC

Thanks, committed:

 2009-01-06  Tim-Philipp Müller  <tim.muller at collabora co uk>

	* gst-libs/gst/app/gstappsink.c:
	* gst-libs/gst/app/gstappsink.h:
	* gst-libs/gst/app/gstappsrc.c:
	* gst-libs/gst/app/gstappsrc.h:
	  Make debug categories static. Use _element_class_set_details_simple().

 2009-01-06  Tim-Philipp Müller  <tim.muller at collabora co uk>

	* gst-libs/gst/app/gstappsink.c: (_GstAppSinkPrivate),
	  (gst_app_sink_class_init), (gst_app_sink_init),
	  (gst_app_sink_dispose), (gst_app_sink_finalize),
	  (gst_app_sink_unlock_start), (gst_app_sink_unlock_stop),
	  (gst_app_sink_flush_unlocked), (gst_app_sink_start),
	  (gst_app_sink_stop), (gst_app_sink_event), (gst_app_sink_preroll),
	  (gst_app_sink_render), (gst_app_sink_getcaps),
	  (gst_app_sink_set_caps), (gst_app_sink_get_caps),
	  (gst_app_sink_is_eos), (gst_app_sink_set_emit_signals),
	  (gst_app_sink_get_emit_signals), (gst_app_sink_set_max_buffers),
	  (gst_app_sink_get_max_buffers), (gst_app_sink_set_drop),
	  (gst_app_sink_get_drop), (gst_app_sink_pull_preroll),
	  (gst_app_sink_pull_buffer):
	* gst-libs/gst/app/gstappsink.h: (GstAppSinkPrivate), (_GstAppSink):
	* gst-libs/gst/app/gstappsrc.c: (_GstAppSrcPrivate),
	  (gst_app_src_class_init), (gst_app_src_init),
	  (gst_app_src_flush_queued), (gst_app_src_dispose),
	  (gst_app_src_finalize), (gst_app_src_set_property),
	  (gst_app_src_get_property), (gst_app_src_unlock),
	  (gst_app_src_unlock_stop), (gst_app_src_start), (gst_app_src_stop),
	  (gst_app_src_is_seekable), (gst_app_src_check_get_range),
	  (gst_app_src_query), (gst_app_src_do_seek), (gst_app_src_create),
	  (gst_app_src_set_caps), (gst_app_src_get_caps),
	  (gst_app_src_set_size), (gst_app_src_get_size),
	  (gst_app_src_set_stream_type), (gst_app_src_get_stream_type),
	  (gst_app_src_set_max_bytes), (gst_app_src_get_max_bytes),
	  (gst_app_src_set_latencies), (gst_app_src_set_latency),
	  (gst_app_src_get_latency), (gst_app_src_push_buffer_full),
	  (gst_app_src_push_buffer_action), (gst_app_src_end_of_stream):
	* gst-libs/gst/app/gstappsrc.h: (GstAppSrcPrivate):
	  Move private data into a private instance struct. Add padding to
	  instance and class structures exposed in public headers. Add
	  Since markers to the gtk-doc blurbs (#566750).