Created attachment 126249 [details] [review]
Improve karma detection & add OnTracksAdded call

Please try this patch in combination with my instructions at http://bobcopeland.com/karma/banshee (to be posted shortly)

Thanks Bob, committed.  How stable/functional is the Karma support now, Bob?

It's stable enough, the missing parts are:
 . Syncing - it looks like ipod grew a lot of code to support that recently.  The pre-1.0 code supported it for Karma but I haven't kept up.
 . Mass storage plugin needs to blacklist the Karma.  Easiest way would be to skip Karmas based on vendor/product ids, unless .is_audio_player file exists.  I haven't done that yet, only because I don't know where the ID should live and hard-coding the vendor/product IDs in two places is ugly.  Any thoughts?
 . Specialized icons, not too important in my book

(Incidentally, I've been thinking of making a 'karma emulator' to make it possible for non-karma owners to test the stuff -- it would be easy to trick libkarma with a small omfs filesystem image, but I'm not sure how to easily insert fake info into the HAL tree.)

Thanks for this patch. Banshee-1-1.4.2 now detects my karma again.

Back for a test with the latest development version of banshee-1-1.5. The patch is already in the code but banshee doesn't detect any tracks. On the same machine, banshee-1-1.4.3, patched works all right with my karma.

(In reply to comment #5)
> Back for a test with the latest development version of banshee-1-1.5. The patch
> is already in the code but banshee doesn't detect any tracks. On the same
> machine, banshee-1-1.4.3, patched works all right with my karma.
> 

Forget it, it didn't work from "make run" but it does after i installed it in /usr/local...