GNOME Bugzilla – Bug 565617
Please don't hardcode the compiler
Last modified: 2008-12-26 12:29:06 UTC
Please describe the problem: Hi, The configure script checks for gmcs and mcs using AC_PATH_PROG, but then ignores the result and uses gmcs regardless. This means that users cannot override the values at configure time. In Debian/Ubuntu we are shipping a wrapper "csc" to mean the system default compiler - hence we need to override gmcs and ask the build system to use csc for compilation. I'm attaching a minimal SVN diff to enable this functionality. The proper fix is probably to get rid of the extra csc variable in configure.in, but that would be a larger patch. Thanks, Iain Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 125302 [details] [review] patch to allow configure to use other compilers if passed at configure-time
this patch won't work. it's not possible to compile f-spot with mcs. we require gmcs
> The configure script checks for gmcs and mcs using AC_PATH_PROG, but then > ignores the result and uses gmcs regardless. Wrong. We're only checking for gmcs, not for mcs. I'll fix the Makefile.include to use $(CSC) instead of gmcs > This means that users cannot > override the values at configure time. In Debian/Ubuntu we are shipping a > wrapper "csc" to mean the system default compiler - hence we need to override > gmcs and ask the build system to use csc for compilation. I can't see the point of having a wrapper, as both compilers serves different needs... it totally makes sense to build, e.g., gio-sharp with mcs, and in the other hand, it doesn't make any sense to try to build f-spot with anything but gmcs...
Created attachment 125332 [details] [review] proposed fix here's what I'm committing. I'm closing the bug as the initial issue looks solved to me. reopen if you have a better solution for this.