After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565607 - Broken macros in gsturi.h and gstinterface.h
Broken macros in gsturi.h and gstinterface.h
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-25 10:02 UTC by Masatake YAMATO
Modified: 2009-01-30 18:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch fixing the bug I reported. (719 bytes, patch)
2008-12-25 10:03 UTC, Masatake YAMATO 		none Details | Review
Remove broken macros (2.24 KB, patch)
2008-12-27 16:09 UTC, Tim-Philipp Müller 		committed Details | Review

Description Masatake YAMATO 2008-12-25 10:02:08 UTC 
In GST_URI_HANDLER_CLASS of gst/gsturi.h GstURIHandler is specified as type for casting. I guess it should be GstURIHandlerInterface.

See the patch.
Comment 1 Masatake YAMATO 2008-12-25 10:03:18 UTC 
Created attachment 125297 [details] [review]
A patch fixing the bug I reported.
Comment 2 Tim-Philipp Müller 2008-12-27 16:09:55 UTC 
Created attachment 125388 [details] [review]
Remove broken macros

I think those macros are broken and should just be removed completely.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2009-01-25 18:34:46 UTC 
+1 from me for Tims patch.
Comment 4 Tim-Philipp Müller 2009-01-30 18:29:02 UTC 
commit b4645e277bc8833e08174351d59fec335ee51b59
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Fri Jan 30 18:17:03 2009 +0000

    Remove broken class to interface cast macros from GstUriHandler and GstImplementsInterface headers
    
    Remove class-to-interface-struct cast macros which don't work,
    don't make sense, and in some cases wouldn't even compile if
    used. Removal should be ok seeing that code which uses any of
    these is broken and bound to crash. Fixes #565607.
    
    API: remove GST_IMPLEMENTS_INTERFACE_CLASS
    API: remove GST_IS_IMPLEMENTS_INTERFACE_CLASS
    API: remove GST_URI_HANDLER_CLASS