GNOME Bugzilla – Bug 565607
Broken macros in gsturi.h and gstinterface.h
Last modified: 2009-01-30 18:29:02 UTC
In GST_URI_HANDLER_CLASS of gst/gsturi.h GstURIHandler is specified as type for casting. I guess it should be GstURIHandlerInterface. See the patch.
Created attachment 125297 [details] [review] A patch fixing the bug I reported.
Created attachment 125388 [details] [review] Remove broken macros I think those macros are broken and should just be removed completely.
+1 from me for Tims patch.
commit b4645e277bc8833e08174351d59fec335ee51b59 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Fri Jan 30 18:17:03 2009 +0000 Remove broken class to interface cast macros from GstUriHandler and GstImplementsInterface headers Remove class-to-interface-struct cast macros which don't work, don't make sense, and in some cases wouldn't even compile if used. Removal should be ok seeing that code which uses any of these is broken and bound to crash. Fixes #565607. API: remove GST_IMPLEMENTS_INTERFACE_CLASS API: remove GST_IS_IMPLEMENTS_INTERFACE_CLASS API: remove GST_URI_HANDLER_CLASS