After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565465 - Recognize True/False as well as true/false in config file (patch attached)
Recognize True/False as well as true/false in config file (patch attached)
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.24.x
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-23 14:55 UTC by Jonathan Underwood
Modified: 2009-07-17 18:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
Allow "True"/"False" as options flags in addition to "true"/"false" and 1/0. (981 bytes, patch)
2008-12-23 14:57 UTC, Jonathan Underwood 		none Details | Review

Description Jonathan Underwood 2008-12-23 14:55:59 UTC 
Please describe the problem:
Currently options in custom.conf are turned on with Enable=true, but not Enable=True. Often users type True and then wonder why some feature isn't working. This trivial patch allows True and False.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Jonathan Underwood 2008-12-23 14:57:15 UTC 
Created attachment 125201 [details] [review]
Allow "True"/"False" as options flags in addition to "true"/"false" and 1/0.
Comment 2 Cosimo Cecchi 2008-12-26 11:03:30 UTC 
I'm not a GDM maintainer, but you could use g_ascii_strcasecmp() to compare the two strings regardless of the case instead of manually doing two strcmp().
Comment 3 Ray Strode [halfline] 2009-01-05 19:07:18 UTC 
maybe we should just use rpmatch()?
Comment 4 Ray Strode [halfline] 2009-07-17 18:50:53 UTC 
This got fixed by http://git.gnome.org/cgit/gdm/commit/?id=105fa59118334e838eddf6b1e3ee58bb4ed00c85