GNOME Bugzilla – Bug 56542
Encoding submenu in View menu is broken.
Last modified: 2004-12-22 21:47:04 UTC
The submenus in View->Encoding->Arabic/Baltic/... are broken. All items are displayed in 'Other' category and, Arabic, Baltic, Japanese, etc.. are all empty. I've made a ad-hoc patch to fix this problem.
Created attachment 671 [details] [review] patch against src/embed.c (CVS HEAD)
the menus are certainly not borken for me and other people too otherwise it would have been noticed some time ago this makes me think something is broken on your end your patch is wrong , it just circumvents the translation mechanism thats put in there, maybe your glibc/galeon package/galeon translation are borked now you are not giving any details on what mozilla and galeon version/package you are using this gives me little ground to speculate whats really wrong one thing is certain, this is the first report of broken encoding menu layout for quite some time
most likely your mozilla chrome is misplaced/not installed/broken
OK, to clean up my environment, I've just purged all mozilla and related libraries, and reinstalled them again (from Debian sid latest). Again, rebuild vanilla galeon (CVS HEAD). This time, the encoding submenu are not broken and works fine. Maybe, my environment (probably mozilla chrome) were broken. (When I reported this bug, the contents of 'charset_titles' in embed_create_charset_submenu() are '... (IBM-864)', '... (IBM-864-I)', etc., and _(charset_trans_array[j].charset_title) contains correct entries in ja.po. So, g_list_find_custom() always fail.)
After previous report, I found that mozilla-locale-ja package affects encoding submenu's behaviour. (mozilla-locale-ja is a Debian version of JLP, Japanese Language Pack for Mozilla <http://www.mozilla.gr.jp/jlp/>.) When mozilla-locale-ja (0.9.1-2) are installed, encoding submenus of galeon become broken. When mozilla-locale-ja are not installed, the menus works fine.
ahmm:) i am a dumb shit i'll have to tweak this a bit more and include some more info in mozilla_i18n.c to workaround this thganks for reporting that , i always wandered what will happen if the translation pack is installed but never bothered to check can you please reopen and assign the bug to me : yaneti@declera.com
I see. I'll check constantly CVS HEAD version of galeon. >can you please reopen and assign the bug to me : yaneti@declera.com I tried to reopen this report, but bugzilla says |Only the owner or submitter of the bug, or a sufficiently empowered |user, may make that change to the bug_status field. |Old value: RESOLVED |New value: REOPENED and fail :-( (I've logined correctly bugzilla, but it seems that bugzilla can't recognize me as the reporter)
i committed a fix for that, so it should be really resolved now, reports are welcome
I checked out CVS, compiled, and run with and without JLP. In both case, encoding menu are correctly displayed. Thanks!