After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565376 - Vfolder Missing Conditions
Vfolder Missing Conditions
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Memos
2.26.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
: 476422 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-12-22 19:39 UTC by David Ronis
Modified: 2013-09-13 01:00 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
filter differences (767 bytes, text/plain)
2008-12-23 12:06 UTC, Milan Crha
  Details
proposed eds patch (14.81 KB, patch)
2008-12-23 17:54 UTC, Milan Crha
none Details | Review
proposed eds patch ][ (17.85 KB, patch)
2008-12-23 18:26 UTC, Milan Crha
committed Details | Review
proposed evo patch (21.99 KB, patch)
2008-12-23 18:34 UTC, Milan Crha
committed Details | Review

Description David Ronis 2008-12-22 19:39:26 UTC
Please describe the problem:
I want to be able to exclude specific mboxes (e.g., suspected spam filtered by procmail) or header (again spam related) from the unread vfolder.  It should be easy, except for the fact that the vfolder options don't allow me to select these (or other things like BCC, regexp).  Basically, the vfolder options should be the same as those used in filters.  Well, perhaps not, there should be one more; i.e., "current folder" which would allow matches on the current (i.e., post filtered etc) folder the mail is in.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Milan Crha 2008-12-23 12:06:40 UTC
Created attachment 125189 [details]
filter differences

Here are differences between 3 kinds of options. Filtertypes' Junk Test should be similar to "Status is (not) Junk". I'll merge them, except of the pipe to program, I believe it doesn't make any sense in searches of search folders, it would be only a performance hit there.

I'll add "Folder" "is/is not" for search folders, but I think it will be most usable only with "all criteria are met", otherwise it will not make much sense.
Comment 2 Milan Crha 2008-12-23 12:27:53 UTC
(In reply to comment #1)
> Filtertypes' Junk Test should be similar to "Status is (not) Junk".

Actually it isn't. Junk Test runs a test for where "Status is (not) Junk" is only looking for a Junk flag whether it is set on a message.
Comment 3 Milan Crha 2008-12-23 17:54:31 UTC
Created attachment 125210 [details] [review]
proposed eds patch

for evolution-data-server;

To let it work.
Comment 4 Milan Crha 2008-12-23 18:26:16 UTC
Created attachment 125213 [details] [review]
proposed eds patch ][

for evolution-data-server;

Err, header-contains for any header didn't work for search folders.
Comment 5 Milan Crha 2008-12-23 18:34:12 UTC
Created attachment 125214 [details] [review]
proposed evo patch

for evolution;

I didn't try all the option, I just think it should work as expected. Otherwise will fix it when someone rises a bug report.
Comment 6 David Ronis 2008-12-23 20:56:54 UTC
OK,  applied the patches and rebuilt (something's got to be done for the build system, BTW, minor changes to eds lead to huge rebuilding in evo, and yes I'm using the -c flag for ginstall).

I now get many new options in the vfolders->properties gui; however, something is broken:

I have a local folder called Spam which is a subfolder of "Spam, Viruses, & Bounces".  I wanted to add a condition to the unread vfolder to exclude stuff in Spam.  

What I see initially in the gui is a single rule:

Status is not Junk

I added (or tried to add) a rule:

Message Location is not Spam

I get the standard gui to choose the folder, but when I selected "Spam", I end up with "Spam, Viruses & Bounces"; i.e., the folder one level up.

Worse the rule doesn't work, and the change seems to have broken the rules completely.   Even with the original rule, I see all of my inbox--as if the is no has been changed to is.



Comment 7 David Ronis 2008-12-23 21:01:06 UTC
Forget the last paragraph of my last comment.  Somehow I'd blown away the "status is not read" condition.  With it resorted, the original behavior is recovered.
Comment 8 David Ronis 2008-12-23 21:07:39 UTC
I'm really foggy today--there is no problem.  The reason I thought that the folder wasn't chosen proprely is that the actual string to be used is

Spam, Viruses & Bounces/Spam

Which was too small for the button, given the gui size.  Making it bigger exposed the tail.  Everything is working as expected.


Comment 9 Srinivasa Ragavan 2009-01-08 09:48:18 UTC
Seems fine for me also. To trunk only.
Comment 10 Milan Crha 2009-01-08 11:24:37 UTC
eds part committed to trunk. Committed revision 9887.
evo part committed to trunk. Committed revision 37015.

(Bumped requirement for eds to 2.25.5 in revision 37016.)
Comment 11 Milan Crha 2009-01-08 14:16:33 UTC
*** Bug 476422 has been marked as a duplicate of this bug. ***