After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565218 - GNOME Goal: Clean up GLib and GTK+ includes
GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
git master
Other Linux
: Normal trivial
: ---
Assigned To: Jamie McCracken
Jamie McCracken
Depends on:
Blocks: 563413
 
 
Reported: 2008-12-21 01:08 UTC by Luis Menina
Modified: 2008-12-29 14:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simple patch (8.52 KB, patch)
2008-12-21 01:09 UTC, Luis Menina 		none Details | Review
corrected patch (9.86 KB, patch)
2008-12-21 01:25 UTC, Luis Menina 		committed Details | Review

Description Luis Menina 2008-12-21 01:08:00 UTC 
Correct applications or libraries that don't include
*only* toplevel headers for GLib, GTK, GDK and gdk-pixbuf. This will be useful
to prepare GTK 3.0 migration.

See also http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Comment 1 Luis Menina 2008-12-21 01:09:20 UTC 
Created attachment 125074 [details] [review]
simple patch
Comment 2 Luis Menina 2008-12-21 01:25:38 UTC 
Created attachment 125075 [details] [review]
corrected patch

Corrects a forgotten include, and corrects another GNOME Goal: http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib
by replacing deprecated GLib calls:
g_basename => g_path_get_basename 
g_dirname => g_path_get_dirname
Comment 3 Ivan Frade 2008-12-29 14:12:37 UTC 
Applied in two different commits with minor corrections:

* Fixed the includes in tests/ folder
* Removed a duplicated #include <gtk/gtk.h> in sexy-icon-entry.h

Thanks for the patch!