After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565102 - Notes lost during synchonization
Notes lost during synchonization
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
0.13.x
Other Linux
: Normal critical
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-19 15:59 UTC by Sandy Armstrong
Modified: 2008-12-19 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch queues a save whenever LoadForeignNoteXml is called. (2.55 KB, patch)
2008-12-19 16:05 UTC, Sandy Armstrong
committed Details | Review

Description Sandy Armstrong 2008-12-19 15:59:54 UTC
In certain sync scenarios, it is possible that Tomboy will think several notes have been deleted, and cause them to be removed from all synchronized computers.

Steps to reproduce:

0. Clear sync server; have lots of notes on computer 1 that aren't on computer 2
1. Sync computer 1
2. Sync computer 2
3. Restart Tomboy on computer 2
4. Sync computer 2
5. Sync computer 1

Expected results:

Computer 1 and computer 2 have the same notes, which are equivalent to (computer 1's original notes) + (computer 2's original notes).

Actual results:

Both computers have Computer 2's original notes, but many of Computer 1's original notes are deleted (on both computers).

What's happening here is that when Computer 2 does its original sync (step 2), it is not always saving the new notes to the file system.  So once Tomboy is restarted, the notes disappear, which is interpreted as a willful deletion.  Computer 1 syncs the results of that deletion, and note disappear.

They can be restored from ~/.tomboy/Backup, but you may need to clear out the sync server and start over again.

Will attach the patch that fixes this in Tomboy 0.12.3 and 0.13.2.
Comment 1 Sandy Armstrong 2008-12-19 16:05:28 UTC
Created attachment 125008 [details] [review]
Patch queues a save whenever LoadForeignNoteXml is called.

Turns out fixing bug #543593 got rid of a save we didn't know we were depending on.  This patch fixes it *correctly* by queueing a save whenever LoadForeignNoteXml is called, whether by note synchronization or by the RemoteControl.

Committed to trunk in r2255, gnome-2-24 branch in r2260.
Comment 2 Sandy Armstrong 2008-12-19 16:36:44 UTC
The fix is in Tomboy 0.12.2.  There is no Tomboy 0.12.3.  :-)