Should go into a new Universal Access capplet.

For 2.26, we should just add a checkbox to the "Keyboard Accessibility Audio Feedback" dialog, I think. 

Loosing this is a bit of an ugly regression, so we should get this done, even if it is late already.

anybody volunteering to work on this?

Created attachment 128267 [details] [review]
patch

Here is a patch

Created attachment 128268 [details]
and here is how it looks

Jon proposes that "System Bell" may be too technical. 
Maybe "Alert sound" would be less technical (and picks up the same name we use in the sound capplet. 
"Visual cues for sounds" is what the a11y guys came up with.

Thanks, Matthias. A few comments:

+visual_bell_enable_toggled_cb (GtkWidget *w, GladeXML *dialog)
+{
+	gboolean active = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (w));
+
+	if (notifications_dialog) {
+		gtk_widget_set_sensitive (NWID ("visual_bell_titlebar"), active);
+		gtk_widget_set_sensitive (NWID ("visual_bell_fullscreen"), active);
+	}
+}

Looks like we don't need "active" when notifications_dialog isn't there.

+static GConfEnumStringPair bell_flash_enums[] = {
+        { 0, "frame_flash" },
+        { 1, "fullscreen" },
+        { -1, NULL }
+};

const? Or does that conflict with the gconf function signatures?

More generally, the patch has a few identation issues. Also, minimizing the glade churn would be nice (stuff like that has bitten us before), and there should be standard functions for converting to/from enums in GConfPropertyEditor already so we shouldn't have to duplicate them. I have to admit I haven't checked if they fit here, though.

I agree with Jon regarding "System Bell". "Visual cues for sounds" sounds good to me if that's what the a11y guys prefer.

Created attachment 128400 [details] [review]
new patch

I hope this addresses the issues.

Indeed, the const is missing from the gconf signature, and I can't see any suitable conversion functions in the gconf-peditor header.

(In reply to comment #8)
> I can't see any suitable conversion functions in the gconf-peditor header.

..._new_select_radio_with_enum

There is no enum here, just two string values

Ok to commit this now ?

If you and Andre on one bug imply an automatic freeze break approval... ;-)

I've sent mail

*** Bug 570039 has been marked as a duplicate of this bug. ***