Created attachment 124918 [details] [review]
Asserts and NULL chedk

OK, it doesn't crash, but:
- it asks for a password anyway
- it doesn't tell me what's going wrong (and I'm quite stupid user for sure) :)

Patch pushed to SVN r55.

Created attachment 125946 [details] [review]
proposed ema patch

for evolution-mapi;

I thought about something like this, very simple check before validation.

Looks good. Please commit with translator comments.. 

We need to display error messages on failure to authenticate too. 

Created attachment 126279 [details] [review]
proposed ema patch ][

for evolution-mapi;

improved version, with a message to the user with the result of the authentication process.

What kind of translator comment are you thinking of?

guys.. we need to move the create/delete profile stuff to libexchangemapi :-)

Created attachment 127119 [details] [review]
proposed ema patch ]I[

for evolution-mapi;

OK, I was unable to enable my exchange setup properly, thus I tried to follow Suman's advice, and it works as expected now. My kudos to you, Suman.

In src/libexchangemapi/exchange-mapi-connection.c

> +	/* Initialize a global connection */
> +	if (exchange_mapi_connection_new (profname, password)) {
> +		result = TRUE;
> +		exchange_mapi_account_listener_get_folder_list ();
> +	}

exchange_mapi_account_listener_get_folder_list() call is implicit. Please change that to exchange_mapi_peek_folder_list() 

Approved.

*** Bug 560751 has been marked as a duplicate of this bug. ***

*** Bug 561665 has been marked as a duplicate of this bug. ***

Committed to trunk. Committed revision 83.

It was just copy&paste of the old code, but I changed it as you said, even I do not see any difference (in runtime) at the moment.

*** Bug 568285 has been marked as a duplicate of this bug. ***