GNOME Bugzilla – Bug 564867
Killing the gst-ffmpeg dependency on libbz2
Last modified: 2009-03-05 08:12:50 UTC
Since 0.10.5 gst-ffmpeg requires libbz2. I think GStreamer should not have such a hard dep. (think embedded, windows, people that care about the on-disk size of their apps) and if you really want a bz2 (de)muxer there's one in -bad already. What do you think about killing this dependency ? (patch follows)
Created attachment 124869 [details] [review] patch against 0.10.6 that remove libbz2 dep
It would be better to make the dependency optional via a configure switch or via autodetection (use if available, warn otherwise and don't use it). bz2 is also used in at least one demuxer (the matroska demuxer) and I wouldn't be surprised if it is also used at other places. Could you change your patch to make the dependency optional instead of simply disabling it?
Well I should have checked why ffmpeg needed libbz2 in the first place. grepping around ffmpeg's sources shows that BZ2* symbols are used in the matroska demuxer for bz2 compressed tracks and nowhere else. So, the new patch makes libbz2 optional, issuing a warning when trying to compile gst-ffmpeg whithout libbz2. Feel free to tune the warning message to your taste.
Created attachment 125266 [details] [review] makes libbz2 optional. patch against gst-ffmpeg-0.10.6 I tested it with native builds on x86_64/linux with and without libbz2-dev as well as a cross mingw32 gcc.
commit ac82da060acb9f6d42deba15191efbd692662a75 Author: Damien Lespiau <damien.lespiau@gmail.com> Date: Thu Mar 5 09:10:37 2009 +0100 Make bz2 requirement optional. Fixes #564867