After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564525 - build error, missing lignome/libgnomeui flags
build error, missing lignome/libgnomeui flags
Status: RESOLVED FIXED
Product: gnome-python-desktop
Classification: Deprecated
Component: gnomeapplet
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-14 21:20 UTC by Lucas Rocha
Modified: 2008-12-21 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build (1.51 KB, patch)
2008-12-14 21:21 UTC, Lucas Rocha 		committed Details | Review
also fix it for the autotools mode (572 bytes, patch)
2008-12-19 21:31 UTC, Frederic Peters 		none Details | Review

Description Lucas Rocha 2008-12-14 21:20:44 UTC 
gnome-panel removed libgnomeui from libpanel-applet (r11398) so gnome-python-desktop needs to explicitly add libgnome/libgnomeui flags on build.
Comment 1 Lucas Rocha 2008-12-14 21:21:36 UTC 
Created attachment 124677 [details] [review]
Fix build
Comment 2 Gustavo Carneiro 2008-12-14 22:34:27 UTC 
Assuming the patch makes gnome-python-desktop build with gnome 2.26 but also keeps building with gnome 2.24 (g-p-d hasn't branched for 2.24 yet).  If so, ok to commit.
Comment 3 Luis Medinas 2008-12-15 23:00:20 UTC 
Lucas patch fixes build on 2.26 but didn't try with 2.24 yet. It's should compile on 2.24 too since it's only a matter of headers.
Comment 4 Gustavo Carneiro 2008-12-16 10:49:50 UTC 
Yes, I think so too.  Someone just commit, thanks.
Comment 5 Luis Medinas 2008-12-16 23:52:35 UTC 
Commited to svn trunk.

2008-12-16  Luis Medinas  <lmedinas@gnome.org>

        * gnomeapplet/applet.override:
        * gnomeapplet/appletmodule.c:
        * gnomeapplet/wscript:

        Fix build error with missing libgnome/libgnomeui flags.
        Patch from Lucas Rocha <lucasr@gnome.org> closes bgo #564525

Thanks
Comment 6 Frederic Peters 2008-12-19 21:31:53 UTC 
Created attachment 125030 [details] [review]
also fix it for the autotools mode

This patch fixes the same issue when built using autotools.
Comment 7 Gustavo Carneiro 2008-12-21 15:54:37 UTC 
Committed similar patch (somehow i got no bugzilla email for this, sorry).

But I won't make a new release for this.  Either the release team makes a new release or you fix the scripts to use waf instead of autotools.