After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564507 - AG_GST_BISON_CHECK is broken
AG_GST_BISON_CHECK is broken
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
0.10.22
Other All
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 564361 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-12-14 18:18 UTC by Roland Illig
Modified: 2008-12-15 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch (564 bytes, patch)
2008-12-14 18:19 UTC, Roland Illig 		none Details | Review
The corrected patch (574 bytes, patch)
2008-12-14 18:28 UTC, Roland Illig 		committed Details | Review

Description Roland Illig 2008-12-14 18:18:33 UTC 
The configure check for the Bison version number is broken. It cannot handle versions with more than two components (e.g. 2.4.1).
Comment 1 Roland Illig 2008-12-14 18:19:47 UTC 
Created attachment 124662 [details] [review]
The patch

It also fixes the bad usage "exit(x)?0:1", which should rather be "exit((x)?0:1)".
Comment 2 Roland Illig 2008-12-14 18:28:07 UTC 
Created attachment 124663 [details] [review]
The corrected patch
Comment 3 Sebastian Dröge (slomo) 2008-12-15 07:02:22 UTC 
*** Bug 564361 has been marked as a duplicate of this bug. ***
Comment 4 Sebastian Dröge (slomo) 2008-12-15 07:06:15 UTC 
2008-12-15  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

	Patch by: Roland Illig <roland dot illig at gmx dot de>

	* m4/gst-parser.m4:
	Fix AG_GST_BISON_CHECK to handle version numbers with more than
	two components (i.e. 2.4.1). Fixes bug #564507.
Comment 5 Roland Illig 2008-12-15 09:47:08 UTC 
(In reply to comment #4)
> 2008-12-15  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

Thanks for fixing it so quickly. If you prefer clean code over clumsy code, you can apply the same pattern to the Flex check, further down in the same file. :)

Roland