After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564351 - GNOME Goal: Clean up GLib and GTK+ includes
GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.26.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-12-13 03:56 UTC by Tal Benavidor
Modified: 2013-09-13 00:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
remove the offending include line (388 bytes, patch)
2008-12-13 04:02 UTC, Tal Benavidor 		committed Details | Review

Description Tal Benavidor 2008-12-13 03:56:07 UTC 
http://live.gnome.org/GnomeGoals/CleanupGTKIncludes

Evolution will not compile with G_DISABLE_SINGLE_INCLUDES, GDK_PIXBUF_DISABLE_SINGLE_INCLUDES and GTK_DISABLE_SINGLE_INCLUDES defined.

configure line:

CFLAGS="-DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES"  ./configure --enable-maintainer-mode --prefix /opt/gnome2 --libdir ${exec_prefix}/lib --disable-static --disable-gtk-doc


Compilation of mail/em-icon-stream.c fails with the following message:
-------------------
In file included from em-icon-stream.c:32:
/opt/gnome2/include/gtk-2.0/gdk-pixbuf/gdk-pixbuf-loader.h:27:2: error: #error "Only <gdk-pixbuf/gdk-pixbuf.h> can be included directly."
-------------------

note about versions: i use trunk of practically everything.
Comment 1 Tal Benavidor 2008-12-13 04:02:52 UTC 
Created attachment 124561 [details] [review]
remove the offending include line

remove the offending line:
    #include <gdk-pixbuf/gdk-pixbuf-loader.h>
Comment 2 André Klapper 2008-12-13 21:18:07 UTC 
Do Not Use means Do Not Use. ;-)

CC'ing Matthew as I think that he has also put some work into that IIRC.
Comment 3 Matthew Barnes 2008-12-13 23:13:49 UTC 
I have.  Incoming patches keep causing regressions.

I'm tracking our overall GTK3 compliance here [1].
Next step is to get things compiling with GSEAL_ENABLE.

Patch approved.  Thanks Tal!


[1] http://www.go-evolution.org/GTK3
Comment 4 Matthew Barnes 2008-12-13 23:18:31 UTC 
Committed to trunk (revision 36874).

2008-12-13  Matthew Barnes  <mbarnes@redhat.com>

        ** Fixes bug #564351 (patch by Tal Benavidor)

        * mail/em-icon-stream.c:
        Fix single-header include issue for GdkPixbuf.