After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564192 - build error, missing libgnomeui CFLAGS
build error, missing libgnomeui CFLAGS
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: charpick
git master
Other Linux
: Normal blocker
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-11 22:49 UTC by Frederic Peters
Modified: 2008-12-17 15:56 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Fix build (5.40 KB, patch)
2008-12-14 18:05 UTC, Lucas Rocha 		committed Details | Review

Description Frederic Peters 2008-12-11 22:49:00 UTC 
gnome-panel removed libgnomeui from libpanel-applet (r11398), but gnome-applets does this in its configure.in:
  PKG_CHECK_MODULES(GNOME_APPLETS, libpanelapplet-2.0 >= $LIBPANEL_REQUIRED)

and then it uses GNOME_APPLET_CFLAGS in charpick/Makefile.am:
  INCLUDES =                      \
        -I.                     \
        -I$(srcdir)             \
        $(GNOME_APPLETS_CFLAGS) \
        $(GUCHARMAP_CFLAGS)

and fails on :
  #include <libgnomeui/gnome-help.h>

(full log on http://fixed.gnome.org/builders/gnome-applets-bxlug-sid/builds/0/steps/gnome-applets%20build/logs/stdio)
Comment 1 Lucas Rocha 2008-12-14 18:05:13 UTC 
Created attachment 124661 [details] [review]
Fix build
Comment 2 Luis Medinas 2008-12-16 00:21:53 UTC 
Lucas patch fixes build for me. Please commit to svn trunk.
Comment 3 William Jon McCann 2008-12-17 15:56:01 UTC 
Committed to trunk.