After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564021 - GNOME Goal: Clean up GLib and GTK+ includes
GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-12-10 18:37 UTC by Pedro Fragoso
Modified: 2008-12-14 21:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (38.59 KB, patch)
2008-12-10 18:42 UTC, Pedro Fragoso
none Details | Review
clean up some dup includes (40.48 KB, patch)
2008-12-12 01:30 UTC, Pedro Fragoso
none Details | Review

Comment 1 Pedro Fragoso 2008-12-10 18:42:26 UTC
Created attachment 124372 [details] [review]
proposed patch
Comment 2 Morten Welinder 2008-12-10 22:11:24 UTC
With the change to the gtk/*.h files, anything that includes one of those
files needs not include gtk.h
Comment 3 Jean Bréfort 2008-12-11 10:38:28 UTC
Btw, it was already the case for GLib.
Comment 4 Pedro Fragoso 2008-12-12 01:30:02 UTC
Created attachment 124475 [details] [review]
clean up some dup includes
Comment 5 Morten Welinder 2008-12-14 21:58:46 UTC
Fixed.  You missed a few in the plugins, btw.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.