After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564000 - GNOME Goal: Clean up GLib and GTK+ includes
GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-10 15:29 UTC by Pedro Fragoso
Modified: 2008-12-18 10:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (22.80 KB, patch)
2008-12-10 15:32 UTC, Pedro Fragoso
committed Details | Review

Comment 1 Pedro Fragoso 2008-12-10 15:32:06 UTC
Created attachment 124353 [details] [review]
proposed patch
Comment 2 Jonathan Matthew 2008-12-15 13:20:11 UTC
I fixed up a couple of files you missed and committed it.  Thanks.
Comment 3 Bastien Nocera 2008-12-18 09:05:25 UTC
Sigh. Where's the appropriate sound-juicer bug for those changes?

I'm getting sick of having to police changes to cut'n'paste code not getting back to the upstream.
Comment 4 Jonathan Matthew 2008-12-18 09:40:06 UTC
I was assuming the patch on bug 563798 would contain all the same changes, but it appears it's missing sj-metadata-getter.h.
Comment 5 Bastien Nocera 2008-12-18 10:10:50 UTC
Fixed in sound-juicer now. Please be careful in the future...