GNOME Bugzilla – Bug 563970
build error (missing libgnomeui include)
Last modified: 2008-12-19 23:23:39 UTC
panel-applet.h used to include libgnomeui/gnome-ui-init.h, it has just been removed[1] but then gdict-applet build breaks. gdict-applet.c: In function ‘main’: gdict-applet.c:1328: error: ‘LIBGNOMEUI_MODULE’ undeclared (first use in this function) gdict-applet.c:1328: error: (Each undeclared identifier is reported only once gdict-applet.c:1328: error: for each function it appears in.) gdict-applet.c:1330: error: ‘GNOME_CLIENT_PARAM_SM_CONNECT’ undeclared (first use in this function) make[3]: *** [gnome_dictionary_applet-gdict-applet.o] Error 1 The problem with GNOME_CLIENT_PARAM_SM_CONNECT is similar, gnome-client.h. Adding those two headers to gdict-applet.c should fix the build: #include <libgnomeui/gnome-ui-init.h> #include <libgnomeui/gnome-client.h> [1] http://svn.gnome.org/viewvc/gnome-panel/trunk/libpanel-applet/panel-applet.h?r1=11383&r2=11398
FWIW: + gnome_authentication_manager_init() shouldn't be needed anymore since gdict uses gio now + gdict_create_data_dir() could be called inside gdict_applet_factory() + and therefore, the code could use the standard macro for applets
Created attachment 124636 [details] [review] patch Patch implementing Vincent's suggestions. Would be great if we could commit this before the 2.25.3 release.
looks good to me. please, commit to trunk.
Fixed in trunk. 2008-12-15 Cosimo Cecchi <cosimoc@gnome.org> * src/gdict-applet.c: (gdict_applet_cmd_help), (gdict_applet_factory), (main): Remove libgnome dependency and use stock PANEL_APPLET_BONOBO_FACTORY macro to initialize applet (#563970).