After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563904 - GNOME Goal: Clean up GLib and GTK+ includes
GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal trivial
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 563413
 
 
Reported: 2008-12-09 20:03 UTC by Luis Menina
Modified: 2008-12-10 11:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
patch for gst-plugins-base (3.13 KB, patch)
2008-12-09 20:19 UTC, Luis Menina 		committed Details | Review
patch for gst-plugins-good (148.56 KB, patch)
2008-12-09 20:21 UTC, Luis Menina 		rejected Details | Review

Description Luis Menina 2008-12-09 20:03:34 UTC 
Correct applications or libraries that don't include *only* toplevel headers for GLib, GTK, GDK and gdk-pixbuf. This will be useful to prepare GTK 3.0 migration.

See also http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Comment 1 Luis Menina 2008-12-09 20:19:43 UTC 
Created attachment 124304 [details] [review]
patch for gst-plugins-base
Comment 2 Luis Menina 2008-12-09 20:21:25 UTC 
Created attachment 124305 [details] [review]
patch for gst-plugins-good
Comment 3 Sebastian Dröge (slomo) 2008-12-10 07:11:21 UTC 
Could you attach the second patch again as a unified diff and without all the unrelated changes? :)

Other than that this is the right thing to do... is it still allowed though to directly include gstdio.h?
Comment 4 Sebastian Dröge (slomo) 2008-12-10 08:19:10 UTC 
2008-12-10  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Patch by: Luis Menina <liberforce at freeside dot fr>

        * gst-libs/gst/floatcast/floatcast.h:
        * gst/typefind/gsttypefindfunctions.c:
        Include glib.h instead of a specific GLib header. Including single
        GLib headers is deprecated. Fixes bug #563904.
Comment 5 Sebastian Dröge (slomo) 2008-12-10 08:31:31 UTC 
Actually the -good patch contains no source changes... and -good builds with with -DG_DISABLE_SINGLE_INCLUDES and friends for me.
I've checked all other modules and they're fine too :)
Comment 6 Luis Menina 2008-12-10 11:52:11 UTC 
Oops, sorry for the second patch, switching to cvs when you're used to svn it tricky :-p. What is strange is the fact that updating to newest release marks the po files as modified while I didn't touch them. As some .c files were marked as modified too, I thought I had patched this module for it to compile. Well, anyway, this is one more step towards world dommination :-)