After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563793 - unmount shares when host is unreachable
unmount shares when host is unreachable
Status: RESOLVED OBSOLETE
Product: gvfs
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2008-12-09 01:51 UTC by A. Walton
Modified: 2018-09-21 16:32 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
sftp: unmount if host unreachable (3.50 KB, patch)
2014-11-12 13:10 UTC, Ondrej Holy 		none Details | Review

Description A. Walton 2008-12-09 01:51:09 UTC 
GVFS should have a common API so that backends can easily subscribe to network connections and will all automatically dismount shares when a network connection has been lost.
Comment 1 Alexander Sack 2009-01-26 16:11:08 UTC 
any progress on this? Can this happen during 2.25 cycle still?
Comment 2 Matthias Clasen 2012-06-30 04:24:40 UTC 
We have GNetworkMonitor in gio now
Comment 3 Ondrej Holy 2014-11-12 13:10:14 UTC 
Created attachment 290509 [details] [review]
sftp: unmount if host unreachable

It isn't unusual backends hang/crash when network is changed (e.g. after suspend) therefor we should to use network monitor in backends. I think it affects all backends in different manners. Those hangs could freeze applications or whole desktop (e.g when using sync calls).

Some of those situations are reported (especially for smb):
https://bugzilla.gnome.org/show_bug.cgi?id=725572
https://bugzilla.redhat.com/show_bug.cgi?id=1049867
https://bugzilla.redhat.com/show_bug.cgi?id=909682

There is implementation for sftp backend. Other backends will follow if you like it...
Comment 4 Ross Lagerwall 2014-12-02 22:55:36 UTC 
The patch itself mostly looks OK (although the default port for sftp is 22, not 115, and 0 *is* a valid port number).

However, it is a feature of TCP that various networks can come and go while the connection remains up. For example, if I've got an sftp mount open, I close the lid of my laptop and walk to the next room and carry on working, this patch would unmount the backend (due to suspend) even though the connection is still up and valid.

We need to think carefully about how to apply these changes in a way that they are useful without breaking existing workflows.

Also, any backend which crashes at any point should be fixed :-)
And applications waiting on sync calls should probably also be fixed...
Comment 5 GNOME Infrastructure Team 2018-09-21 16:32:23 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gvfs/issues/76.