After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563764 - GNOME Goal: Clean up GLib and GTK+ includes
GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED FIXED
Product: gnome-mag
Classification: Deprecated
Component: API
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Willie Walker
bill.haneman
Depends on:
Blocks: 563413
 
 
Reported: 2008-12-08 21:03 UTC by Luis Menina
Modified: 2009-07-07 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simple patch (9.70 KB, patch)
2008-12-08 21:07 UTC, Luis Menina 		none Details | Review
corrected patch (10.86 KB, patch)
2008-12-08 21:40 UTC, Luis Menina 		none Details | Review
Corrects the autotools mistake (2.96 KB, patch)
2009-06-05 23:01 UTC, Luis Menina 		committed Details | Review

Description Luis Menina 2008-12-08 21:03:12 UTC 
Correct to track applications or libraries that don't include
*only* toplevel headers for GLib, GTK, GDK and gdk-pixbuf. This will be useful
to prepare GTK 3.0 migration.

See also http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Comment 1 Luis Menina 2008-12-08 21:07:13 UTC 
Created attachment 124208 [details] [review]
simple patch
Comment 2 Luis Menina 2008-12-08 21:40:04 UTC 
Created attachment 124211 [details] [review]
corrected patch
Comment 3 Luis Menina 2009-01-08 00:56:05 UTC 
Could someone review this ?
Comment 4 André Klapper 2009-05-13 17:55:18 UTC 
Luis, what else does that patch cover? There's a lot more in there then just fixing some header files...
Comment 5 Luis Menina 2009-05-15 00:49:43 UTC 
Seems to be an autotools trick... I didn't changed the config files on purpose... I've been away for a moment, so I'm currently in the git migration process, and should be soon able to correct this.
Comment 6 Luis Menina 2009-06-05 23:01:43 UTC 
Created attachment 136040 [details] [review]
Corrects the autotools mistake
Comment 7 Luis Menina 2009-06-13 22:12:33 UTC 
Could somemone review this ? It's pretty straightforward, and I can commit it quickly now that I've commit rights...
Comment 8 Willie Walker 2009-06-20 13:57:24 UTC 
Adding myself as a reminder to build/test this on OpenSolaris.  I'll give the review after I've done that.
Comment 9 Willie Walker 2009-06-20 14:24:56 UTC 
I built this on OpenSolaris and ran the magnifier with "magnifier -z 4 -m -f" and it seemed to work fine.  I also ran it with orca and it worked fine.  So, you get my thumbs up to commit.

Once you commit, please keep this bug open since it will serve as a reminder to someone (most likely me) to create a new release for GNOME 2.26.x and GNOME 2.27.x.
Comment 10 Luis Menina 2009-06-23 23:36:42 UTC 
Thanks for the review. Commit is e17e9b3bab8296f9cddea1a9c2d43bf3e95a375e
As you requested, I leave the bug open for tracking.
Comment 11 Willie Walker 2009-07-07 13:50:50 UTC 
(In reply to comment #10)
> Thanks for the review. Commit is e17e9b3bab8296f9cddea1a9c2d43bf3e95a375e
> As you requested, I leave the bug open for tracking.

The new version has been released with your changes:

http://ftp.gnome.org/pub/GNOME/sources/gnome-mag/0.15/gnome-mag-0.15.7.news

Thanks!