After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563706 - Tracker plugin fails to build against trunk
Tracker plugin fails to build against trunk
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 575341 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-12-08 15:44 UTC by Luca Ferretti
Modified: 2009-03-14 20:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
totem-new-tracker.patch (1.22 KB, patch)
2008-12-08 17:13 UTC, Bastien Nocera 		none Details | Review

Description Luca Ferretti 2008-12-08 15:44:24 UTC 
tracker-client.h no longer exist in trunk

To fix the build (don't yet checked at runtime) you need:
--- src/plugins/tracker/totem-tracker-widget.c	(revisione 5829)
+++ src/plugins/tracker/totem-tracker-widget.c	(copia locale)
@@ -28,10 +28,10 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <libintl.h>
-#include <tracker.h>
-#include <tracker-client.h>
 #include <glib/gi18n-lib.h>
 #include <gio/gio.h>
+#include <dbus/dbus.h>
+#include <tracker.h>
 
 #include "totem-tracker-widget.h"

This, of course, will break the build against released tracker 0.6.6 :)

Please note that #include order and additional dbus.h count as per this[1] ml thread.

[1] http://mail.gnome.org/archives/tracker-list/2008-December/msg00048.html
Comment 1 Bastien Nocera 2008-12-08 17:12:31 UTC 
(In reply to comment #0)
> tracker-client.h no longer exist in trunk
> 
> To fix the build (don't yet checked at runtime) you need:
> --- src/plugins/tracker/totem-tracker-widget.c  (revisione 5829)
> +++ src/plugins/tracker/totem-tracker-widget.c  (copia locale)
> @@ -28,10 +28,10 @@
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <libintl.h>
> -#include <tracker.h>
> -#include <tracker-client.h>
>  #include <glib/gi18n-lib.h>
>  #include <gio/gio.h>
> +#include <dbus/dbus.h>
> +#include <tracker.h>
> 
>  #include "totem-tracker-widget.h"
> 
> This, of course, will break the build against released tracker 0.6.6 :)

It seemed to work just fine against 0.6.6 with the changes you made.

> Please note that #include order and additional dbus.h count as per this[1] ml
> thread.
> 
> [1] http://mail.gnome.org/archives/tracker-list/2008-December/msg00048.html

That's a bug in tracker.h. It should include any headers it actually uses...
Comment 2 Bastien Nocera 2008-12-08 17:13:51 UTC 
Created attachment 124191 [details] [review]
totem-new-tracker.patch

In case my commit will break older older versions of Tracker.
Comment 3 Bastien Nocera 2008-12-08 17:15:06 UTC 
2008-12-08  Bastien Nocera  <hadess@hadess.net>

	* src/plugins/tracker/totem-tracker-widget.c:
	Fix building with newer versions of tracker (Closes: #563706)
Comment 4 Martyn Russell 2008-12-09 09:34:18 UTC 
I have fixed the #include situation in <tracker.h>(In reply to comment #1)
> (In reply to comment #0)
> > Please note that #include order and additional dbus.h count as per this[1] ml
> > thread.
> > 
> > [1] http://mail.gnome.org/archives/tracker-list/2008-December/msg00048.html
> 
> That's a bug in tracker.h. It should include any headers it actually uses...

Hi Bastien.

I have fixed this. It was including the lower level DBus #includes but not glib before that, the fix includes:

-#include <dbus/dbus.h>
-#include <dbus/dbus-glib-lowlevel.h>
-#include <dbus/dbus-glib.h>
+#include <dbus/dbus-glib-bindings.h>

The .c file simply includes tracker.h now too.
Note, the dbus/dbus-glib-bindings.h file actually includes glib.h for us.
Comment 5 Philip Withnall 2009-03-14 20:24:17 UTC 
*** Bug 575341 has been marked as a duplicate of this bug. ***