After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563684 - GNOME Goal: Clean up GLib and GTK+ includes
GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: gail
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Li Yuan
Li Yuan
Depends on:
Blocks: 563413
 
 
Reported: 2008-12-08 13:19 UTC by Przemysław Grzegorczyk
Modified: 2010-03-02 07:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (17.00 KB, patch)
2008-12-08 13:20 UTC, Przemysław Grzegorczyk
none Details | Review
patch for libgail-gnome (2.98 KB, patch)
2008-12-09 00:56 UTC, Luis Menina
committed Details | Review

Description Przemysław Grzegorczyk 2008-12-08 13:19:45 UTC
http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Comment 1 Przemysław Grzegorczyk 2008-12-08 13:20:33 UTC
Created attachment 124163 [details] [review]
patch
Comment 2 Christian Persch 2008-12-08 13:38:40 UTC
Standalone-Gail is obsolete.
Comment 3 Luis Menina 2008-12-08 15:21:21 UTC
But it breaks the build using jhbuild with
make CFLAGS+="-DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES"

What do you suggest ?
Comment 4 Luis Menina 2008-12-09 00:56:34 UTC
Created attachment 124225 [details] [review]
patch for libgail-gnome

additional patch for libgail-gnome
Comment 5 Matthias Clasen 2008-12-10 17:53:25 UTC
Moving this to atk/gail, no idea where libgail-gnome bugs belong...
Comment 6 André Klapper 2009-01-25 21:24:11 UTC
Li Yuan: ping
Comment 7 Li Yuan 2009-02-02 03:03:10 UTC
Actually we need two bugs here. One for gtk+/gail, one for libgail-gnome.
Comment 8 André Klapper 2009-05-13 17:55:53 UTC
Li: Still, can get this part in?
Comment 9 Luis Menina 2009-06-13 22:10:10 UTC
ping
Comment 10 Li Yuan 2009-06-15 03:25:03 UTC
the patch for libgail-gnome has been accepted, please commit that patch and move the bug to gtk+
Comment 11 Luis Menina 2009-06-16 21:15:13 UTC
Thanks, commited as fd9ba69..d8c4089.

Moving the bug report to the GTK+/gail component.
Comment 12 Luis Menina 2009-06-16 21:20:40 UTC
Hum... Looking at the GTK+/gail module, I don't see a reason why you told me to transfer the bug to it. I saw no problem with the headers there, Li. Did I overlooked something ?
Comment 13 Li Yuan 2009-07-21 12:10:42 UTC
Oh, so your patch is made for the gail module. That module is obsolete because it has been moved into GTK+. So I am going to close this bug as fixed.
Comment 14 Li Yuan 2009-07-21 12:13:18 UTC
And I don't think it should be built by jhbuild.
Comment 15 André Klapper 2009-07-21 12:38:31 UTC
According to GNOME 2.28 jhbuild modulesets:

  <autotools id="at-poke">
    <branch/>
    <dependencies>
      <dep package="libgail-gnome"/>
    </dependencies>

  <autotools id="orca">
    <branch/>
    <dependencies>
      <dep package="intltool"/>
      <dep package="gnome-python"/>
      <dep package="libgail-gnome"/>
      <dep package="gnome-mag"/>
      <dep package="gnome-speech"/>
    </dependencies>
  </autotools>

If that is not true anymore and deps should be changed from libgail-gnome to gtk+: Please say.
Comment 16 André Klapper 2009-07-21 12:42:49 UTC
(In reply to comment #15)
>   <autotools id="at-poke">

http://git.gnome.org/cgit/at-poke/commit/?id=09ff6875f9389734971ce851a56b7cf6f4df3662 removed libgail.

So this is a jhbuild bug.

>   <autotools id="orca">

In configure.in there is
  gail >= 1.8.11
In orca.spec.in there is
  %define gail_version 1.8.11
  %define libgail_version 1.1.3

So Orca is probably the reason why jhbuild still builds libgail-gnome.
Comment 17 André Klapper 2009-07-21 13:06:31 UTC
at-poke deps are fixed in jhbuild now.
I've filed bug 589244 about Orca.

Thanks for coming up with this. :-)