Created attachment 124163 [details] [review]
patch

Standalone-Gail is obsolete.

But it breaks the build using jhbuild with
make CFLAGS+="-DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES"

What do you suggest ?

Created attachment 124225 [details] [review]
patch for libgail-gnome

additional patch for libgail-gnome

Moving this to atk/gail, no idea where libgail-gnome bugs belong...

Li Yuan: ping

Actually we need two bugs here. One for gtk+/gail, one for libgail-gnome.

Li: Still, can get this part in?

ping

the patch for libgail-gnome has been accepted, please commit that patch and move the bug to gtk+

Thanks, commited as fd9ba69..d8c4089.

Moving the bug report to the GTK+/gail component.

Hum... Looking at the GTK+/gail module, I don't see a reason why you told me to transfer the bug to it. I saw no problem with the headers there, Li. Did I overlooked something ?

Oh, so your patch is made for the gail module. That module is obsolete because it has been moved into GTK+. So I am going to close this bug as fixed.

And I don't think it should be built by jhbuild.

According to GNOME 2.28 jhbuild modulesets:

  <autotools id="at-poke">
    <branch/>
    <dependencies>
      <dep package="libgail-gnome"/>
    </dependencies>

  <autotools id="orca">
    <branch/>
    <dependencies>
      <dep package="intltool"/>
      <dep package="gnome-python"/>
      <dep package="libgail-gnome"/>
      <dep package="gnome-mag"/>
      <dep package="gnome-speech"/>
    </dependencies>
  </autotools>

If that is not true anymore and deps should be changed from libgail-gnome to gtk+: Please say.

(In reply to comment #15)
>   <autotools id="at-poke">

http://git.gnome.org/cgit/at-poke/commit/?id=09ff6875f9389734971ce851a56b7cf6f4df3662 removed libgail.

So this is a jhbuild bug.

>   <autotools id="orca">

In configure.in there is
  gail >= 1.8.11
In orca.spec.in there is
  %define gail_version 1.8.11
  %define libgail_version 1.1.3

So Orca is probably the reason why jhbuild still builds libgail-gnome.

at-poke deps are fixed in jhbuild now.
I've filed bug 589244 about Orca.

Thanks for coming up with this. :-)