GNOME Bugzilla – Bug 563636
Use single GTK includes
Last modified: 2019-02-23 02:48:44 UTC
http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Created attachment 124142 [details] [review] Use single includes
Thanks! Please commit to trunk.
Thanks chpe, but i don't have a svn access. Someone feel free to commit this.
Created attachment 124730 [details] [review] xchat-gnome fixed patch This patch is a fixed version of Pedro's patch. gdkkeysyms.h is not included in gdk.h so can't be replaced by gdk.h. To compile xchat-gnome with single includes flags libsexy need to be fixed (bug 564615).
Committed, thanks for the patches!
I can't compile with -DGTK_DISABLE_SINGLE_INCLUDES Maybe because bug #564615 is not fixed ?
reopening, based on chat in #bugs. User will add more data.
I download xchat from gnome git repository today (2009/05/05)
This is the error: " In file included from /usr/include/libsexy/sexy-spell-entry.h:28, from text-entry.h:24, from fe-gnome.c:40: /usr/include/gtk-2.0/gtk/gtkentry.h:32:2: error: #error "Only <gtk/gtk.h> can be included directly." make[4]: *** [xchat_gnome-fe-gnome.o] Error 1 make[3]: *** [all] Error 2 make[2]: *** [all-recursive] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 "
That's a bug in libsexy then, which I thought was fixed already (bug 564615).
note: http://live.gnome.org/GnomeGoals/DropLibsexy
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
correction, issue lies with libsexy and not xchat-gnome.
Two items remains here 1. libsexy - to be dropped, once we have a replacement for SexySpellEntry. Workaround, manually edit "libsexy/sexy-spell-entry.h", to use "<gtk/gtk.h>" 2. gdk/gdkkeysyms.h awaiting feedback on http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Not done as comment 14 point 1. Reopening and adding dependency.
xchat-gnome is not under active development anymore. Its codebase has been archived: https://gitlab.gnome.org/Archive/xchat-gnome/commits/master Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather reactivate the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again. You may want to switch to Hexchat (or another IRC client that suits you).