After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563414 - Fix for SunAudioMixer plugin
Fix for SunAudioMixer plugin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other opensolaris
: Normal normal
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-06 04:22 UTC by Brian Cameron
Modified: 2009-01-23 01:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
patch fixing problem (496 bytes, patch)
2008-12-07 19:18 UTC, Brian Cameron 		committed Details | Review

Description Brian Cameron 2008-12-06 04:22:58 UTC 
The SunAudioMixer has a bug where it tries to call the AUDIO_MIXER_MULTIPLE_OPEN ioctl before setting the mixer->mixer_fd argument, so this always fails.  The attached patch fixes this obvious error in the plugin.  Can this go upstream?
Comment 1 Sebastian Dröge (slomo) 2008-12-06 09:24:36 UTC 
You forgot to actually attach the patch :)
Comment 2 Brian Cameron 2008-12-07 19:18:21 UTC 
Created attachment 124119 [details] [review]
patch fixing problem


Sorry about that, here is the patch.
Comment 3 Sebastian Dröge (slomo) 2008-12-07 19:22:44 UTC 
2008-12-07  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Patch by: Brian Cameron <brian.cameron at sun dot com>

        * sys/sunaudio/gstsunaudiomixerctrl.c:
        (gst_sunaudiomixer_ctrl_open):
        Set the mixer fd before calling ioctl() on it. Fixes bug #563414.
Comment 4 Brian Cameron 2009-01-23 01:15:54 UTC 
I notice this fix is not in the latest gst-plugins-good 0.10.13.  Any reason why this wasn't included in that new release if this was committed on 12/07/2008?
Comment 5 Michael Smith 2009-01-23 01:19:07 UTC 
I believe 0.10.12 and 0.10.13 were releases based on 0.10.11 with security fixes; they weren't made from trunk, or whatever trunk is supposed to be called now.

The next "full" release of gst-plugins-good after 0.10.11 will be 0.10.14