GNOME Bugzilla – Bug 563414
Fix for SunAudioMixer plugin
Last modified: 2009-01-23 01:19:07 UTC
The SunAudioMixer has a bug where it tries to call the AUDIO_MIXER_MULTIPLE_OPEN ioctl before setting the mixer->mixer_fd argument, so this always fails. The attached patch fixes this obvious error in the plugin. Can this go upstream?
You forgot to actually attach the patch :)
Created attachment 124119 [details] [review] patch fixing problem Sorry about that, here is the patch.
2008-12-07 Sebastian Dröge <sebastian.droege@collabora.co.uk> Patch by: Brian Cameron <brian.cameron at sun dot com> * sys/sunaudio/gstsunaudiomixerctrl.c: (gst_sunaudiomixer_ctrl_open): Set the mixer fd before calling ioctl() on it. Fixes bug #563414.
I notice this fix is not in the latest gst-plugins-good 0.10.13. Any reason why this wasn't included in that new release if this was committed on 12/07/2008?
I believe 0.10.12 and 0.10.13 were releases based on 0.10.11 with security fixes; they weren't made from trunk, or whatever trunk is supposed to be called now. The next "full" release of gst-plugins-good after 0.10.11 will be 0.10.14