Created attachment 124038 [details] [review]
Add gproperties to MetaWindow: "title", "icon", "mini-icon"

We need these properties to do things outside of the frame, without
dropping to libwnck.

+  if (modified)
+    g_object_notify (G_OBJECT (window), "title");

Suggest notifying at the end after ::desc has been updated.

+  g_object_class_install_property (object_class,
+                                   PROP_TITLE,
+                                   g_param_spec_string ("title",
+                                                        "Window title",
+                                                        "",
+                                                        "",
+                                                        G_PARAM_READABLE));  

Nick should be "Title" to match the name of the property. Nicks are always
the name nicely formatted.

Description should be "The title of the window" if you can't think of anything more useful to say.

Same applies to the other two properties. Is there any reason to use ""
rather than NULL for the default? (default matters here really not at all,
so might as well keep it simple.)

+      
+      g_object_notify (G_OBJECT (window), "icon");
+      g_object_notify (G_OBJECT (window), "mini-icon");    

Good practice to surround multiple notifications with a g_object_freeze_notify()
g_object_thaw_notify() pair. Otherwise looks fine to me.

- Owen

Created attachment 124040 [details] [review]
Add gproperties to MetaWindow: "title", "icon", "mini-icon"

We need these properties to do things outside of the frame, without
dropping to libwnck.

Thanks, all fixed.

commit 4fc9c5ace4394d4504d6c3ba2457a00724d78b2b
Author: Colin Walters <walters@verbum.org>
Date:   Fri Dec 5 20:03:27 2008 -0500

    Add gproperties to MetaWindow: "title", "icon", "mini-icon"
    
    We need these properties to do things outside of the frame, without
    dropping to libwnck.
    
    http://bugzilla.gnome.org/show_bug.cgi?id=563405