After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563168 - TagLib#: cover art in Ogg/Vorbis files
TagLib#: cover art in Ogg/Vorbis files
Status: RESOLVED FIXED
Product: taglib-sharp
Classification: Other
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-03 21:41 UTC by John Millikin
Modified: 2009-01-16 02:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support Ogg/Vorbis cover art (4.88 KB, patch)
2008-12-03 21:42 UTC, John Millikin 		needs-work Details | Review
Support Ogg/Vorbis cover art (v2) (1.41 KB, patch)
2009-01-13 02:30 UTC, John Millikin 		none Details | Review
John, your latest patch didn't compile - please test the slightly modified version I've attached. (1.85 KB, patch)
2009-01-13 03:52 UTC, Gabriel Burt 		committed Details | Review

Description John Millikin 2008-12-03 21:41:49 UTC 
TagLib# doesn't extract cover art from Ogg/Vorbis media. It should read the COVERART tag, which stores the cover encoded in base64.
Comment 1 John Millikin 2008-12-03 21:42:10 UTC 
Created attachment 123902 [details] [review]
Support Ogg/Vorbis cover art
Comment 2 Gabriel Burt 2009-01-13 00:49:47 UTC 
Hi John,

Thanks for the patch.  Why didn't you reuse the TagLib.Picture class?  I think you could inherit yours from it to avoid some duplication.  You can change the FillInMimeFromData method to protected if you need to.

Besides that, looks good - I look forward to an updated version!

Gabriel
Comment 3 John Millikin 2009-01-13 02:30:42 UTC 
Created attachment 126327 [details] [review]
Support Ogg/Vorbis cover art (v2)

> Why didn't you reuse the TagLib.Picture class?

Wasn't aware of it, thanks for mentioning; using that class removed most of the added code.
Comment 4 Gabriel Burt 2009-01-13 03:52:26 UTC 
Created attachment 126330 [details] [review]
John, your latest patch didn't compile - please test the slightly modified version I've attached.
Comment 5 John Millikin 2009-01-13 04:23:29 UTC 
Thanks for the changes, they look good. Unfortunately I'm not able to compile TagLib# at the moment (hence earlier errors), but the code added is simple enough that I trust your version.
Comment 6 Gabriel Burt 2009-01-15 18:48:27 UTC 
Hey John, will you be able to build/test this at some point?  I don't have a lot of time to work on it, so if you could that would be great.
Comment 7 John Millikin 2009-01-15 22:22:46 UTC 
Just tested it, works perfectly.
Comment 8 Gabriel Burt 2009-01-16 02:08:31 UTC 
Thanks John, committed!