After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562998 - GtkFontButton documentation improvements
GtkFontButton documentation improvements
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
2.14.x
Other All
: Normal minor
: ---
Assigned To: Sven Herzberg
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-12-02 16:20 UTC by Sven Herzberg
Modified: 2008-12-03 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed Patch (667 bytes, patch)
2008-12-02 16:21 UTC, Sven Herzberg 		none Details | Review
More info (858 bytes, patch)
2008-12-02 16:54 UTC, Nelson Benitez 		none Details | Review
Updated more info doc patch (855 bytes, patch)
2008-12-02 19:02 UTC, Nelson Benitez 		committed Details | Review

Description Sven Herzberg 2008-12-02 16:20:51 UTC 
Documentation 
Section: gtk_font_button_get_name()
Retrieves the name of the currently selected font.

Correct version:
Retrieves the name of the currently selected font. This name includes
style and size information as well. Instead of parsing the string, it
should be used as an argument for pango_font_description_from_name().

Other information:
Adding patch
Comment 1 Sven Herzberg 2008-12-02 16:21:55 UTC 
Created attachment 123807 [details] [review]
Proposed Patch
Comment 2 Nelson Benitez 2008-12-02 16:54:21 UTC 
Created attachment 123811 [details] [review]
More info

Here's another version with more info for the developer.

thanks sven!
Comment 3 Sven Herzberg 2008-12-02 17:47:18 UTC 
Comment on attachment 123811 [details] [review]
More info

>+ * style and size information as well. If you want to render something
>+ * with the font, use pango_font_description_from_string() with this font 
>+ * description. If you're interested in peeking certain values (family name,

Actually, you shouldn't call this string a "font description", because that's basically what a PangoFontDescription _really_ is. Better write "this string" or "the result".
Comment 4 Nelson Benitez 2008-12-02 19:02:13 UTC 
Created attachment 123816 [details] [review]
Updated more info doc patch

Done, :-)
Comment 5 Emmanuele Bassi (:ebassi) 2008-12-03 09:55:36 UTC 
please, use "#PangoFontDescription" to get a nice cross-reference link to the Pango documentation for the PangoFontDescription API. other than that, it's pretty much good to be committed.
Comment 6 Sven Herzberg 2008-12-03 13:16:07 UTC 
Committed to revision 21842:

2008-12-03  Sven Herzberg  <sven@imendio.com>

        Bug 562998 – GtkFontButton documentation improvements

        * gtk/gtkfontbutton.c: mention the way the font string should be used.
        Patch by Sven Herzberg and Nelson Benitez