After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562716 - warning fixing cause more warnings.
warning fixing cause more warnings.
Status: RESOLVED FIXED
Product: glibmm
Classification: Bindings
Component: general
2.18.x
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2008-11-29 21:56 UTC by Hubert Figuiere (:hub)
Modified: 2008-12-01 07:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.02 KB, patch)
2008-11-29 21:57 UTC, Hubert Figuiere (:hub) 		committed Details | Review

Description Hubert Figuiere (:hub) 2008-11-29 21:56:35 UTC 
some warning fixing cause  more warning in g++.

attached is a patch to do it the right way.
Comment 1 Hubert Figuiere (:hub) 2008-11-29 21:57:15 UTC 
Created attachment 123669 [details] [review]
patch
Comment 2 Hubert Figuiere (:hub) 2008-11-29 21:58:06 UTC 
Here are the warnings the patch suppresses:

markup.cc:107: warning: the address of ‘error’ will always evaluate as ‘true’
markup.cc: In static member function ‘static void Glib::Markup::ParserCallbacks::end_element(GMarkupParseContext*, const char*, void*, GError**)’:
markup.cc:148: warning: the address of ‘error’ will always evaluate as ‘true’
markup.cc: In static member function ‘static void Glib::Markup::ParserCallbacks::text(GMarkupParseContext*, const char*, gsize, void*, GError**)’:
markup.cc:177: warning: the address of ‘error’ will always evaluate as ‘true’
markup.cc: In static member function ‘static void Glib::Markup::ParserCallbacks::passthrough(GMarkupParseContext*, const char*, gsize, void*, GError**)’:
markup.cc:206: warning: the address of ‘error’ will always evaluate as ‘true’
Comment 3 Murray Cumming 2008-11-30 23:42:53 UTC 
Please commit. That is indeed much nicer.
Comment 4 Hubert Figuiere (:hub) 2008-12-01 07:14:29 UTC 
ok committed.