GNOME Bugzilla – Bug 562716
warning fixing cause more warnings.
Last modified: 2008-12-01 07:14:29 UTC
some warning fixing cause more warning in g++. attached is a patch to do it the right way.
Created attachment 123669 [details] [review] patch
Here are the warnings the patch suppresses: markup.cc:107: warning: the address of ‘error’ will always evaluate as ‘true’ markup.cc: In static member function ‘static void Glib::Markup::ParserCallbacks::end_element(GMarkupParseContext*, const char*, void*, GError**)’: markup.cc:148: warning: the address of ‘error’ will always evaluate as ‘true’ markup.cc: In static member function ‘static void Glib::Markup::ParserCallbacks::text(GMarkupParseContext*, const char*, gsize, void*, GError**)’: markup.cc:177: warning: the address of ‘error’ will always evaluate as ‘true’ markup.cc: In static member function ‘static void Glib::Markup::ParserCallbacks::passthrough(GMarkupParseContext*, const char*, gsize, void*, GError**)’: markup.cc:206: warning: the address of ‘error’ will always evaluate as ‘true’
Please commit. That is indeed much nicer.
ok committed.