GNOME Bugzilla – Bug 562553
Back history menus are flipped
Last modified: 2009-02-23 12:03:52 UTC
The Back toolbutton menu lists the previous visited pages in reverse order, i.e. the previous one is the last enty of the list Example: * go to google.com * go to yahoo.com * go to gnome.org * go to kde.org Expected result: The menu obtained clicking on Back toolbutton arrow should be 1) gnome.org 2) yahoo.com 3) google.com Current results The menu is instead: 1) google.com 2) yahoo.com 3) gnome.org Maybe some changes in latest webkit history code?
Not sure if a webkit bug or just us that are missing a g_list_reverse. Anyone knows how the webkit api is expected to be used wrt this?
Some days ago I tried this change - l = list; + l = g_list_reverse (list); in build_back_or_forward_menu() function. Not sure, but I remember that this fixed the Back menu, but not the Forward. But was just a quick and stupid test.
--- ephy-navigation-action.c (revisione 8629) +++ ephy-navigation-action.c (copia locale) @@ -230,7 +230,7 @@ menu = GTK_MENU_SHELL (gtk_menu_new ()); - l = list; + l = g_list_reverse (list); for (l = list; l != NULL; l = l->next) { This is was I tried, but g_list_reverse() simply switch previous and next pointer, so the history menus are totally messed :(
Hi! This is likely a bug in webkit/gtk. Can you please file a bug in http://bugs.webkit.org and assign it to me (jmalonzo@gmail.com)? Thanks!
(In reply to comment #4) > Hi! This is likely a bug in webkit/gtk. Can you please file a bug in > http://bugs.webkit.org and assign it to me (jmalonzo@gmail.com)? > https://bugs.webkit.org/show_bug.cgi?id=22694 (added you in CC, I can't assing)
We need to re-think the Back/Forward menu structure anyway. See bug 161872 and recent requests prompted by Firefox' new navigation menu.
This was fixed in WebKit trunk.