After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562371 - overwriting themes not possible
overwriting themes not possible
Status: RESOLVED OBSOLETE
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
: 562587 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-11-26 20:16 UTC by Bernhard Koenig
Modified: 2017-06-07 00:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
smoked glass from gnome-look.org (56.48 KB, application/x-gzip)
2008-11-27 18:24 UTC, Bernhard Koenig
Details
Screenshot (86.81 KB, image/png)
2008-11-27 18:30 UTC, Bernhard Koenig
Details

Description Bernhard Koenig 2008-11-26 20:16:07 UTC
Please describe the problem:
Say I install a gtk theme by dragging it into gnome-appearance and then delete it by clicking on "delete". Then this theme is still in ~/.themes. This can cause serious problems e.g. if I reinstall the same theme: then I get an error "cannot move folder over folder".

Steps to reproduce:
1. install gtk theme
2. delete gtk theme in gnome-appearance
3. reinstall same theme


Actual results:
error message "cannot move folder over folder"

Expected results:
theme data should be deleted in .themes

Does this happen every time?
yes

Other information:
related bug in launchpad: https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/301749
Comment 1 Jens Granseuer 2008-11-27 17:38:05 UTC
What version is that? What theme does it fail to delete? What does "theme is still in .themes" mean? The entire theme, parts of the theme?

The problem is not reproducable here with 2.24.0.1.
Comment 2 Bernhard Koenig 2008-11-27 17:53:01 UTC
I have 2.24.1 on intrepid and you can use any theme, imho. It's still in .themes means that I have the whole theme folder (including all png files etc.) in .themes and I have to delete it manually.

I could attach the folder here, but it's basically the whole theme data (unzipped).
Comment 3 Bernhard Koenig 2008-11-27 18:07:09 UTC
Btw, the theme does not show up in gnome-appearance-properties anymore after deletion but all the data is still stored in .themes (basically everything that was originally put there, .themes is completely untouched by deletion).
Comment 4 Jens Granseuer 2008-11-27 18:12:45 UTC
Please attach an affected theme here.
Comment 5 Bernhard Koenig 2008-11-27 18:24:08 UTC
Created attachment 123564 [details]
smoked glass from gnome-look.org

This is the zipped theme that I drag onto gnome-appearance.
Comment 6 Bernhard Koenig 2008-11-27 18:27:29 UTC
I also get these funny folders after unsuccessful attempts to reinstall, see screenshot.
Comment 7 Bernhard Koenig 2008-11-27 18:30:52 UTC
Created attachment 123565 [details]
Screenshot

The data of the theme and some funny folders.
Comment 8 Jens Granseuer 2008-11-27 18:37:23 UTC
Ok, several observations:

1) g-c-c 2.24.1 hasn't actually been released yet
2) the theme you attached is a "Gnome" theme, including a metatheme, a gtk theme, and a metacity theme
3) deleting the Smoked Ice gtk theme only deletes the gtk theme, not the metatheme or the metacity theme
4) if you try to reinstall the theme before deleting all three themes, that won't work
5) This could be an enhancement request to
   a) make overwriting themes possible
   b) properly clean up after a failed installation attempt
Comment 9 Bernhard Koenig 2008-11-27 18:58:20 UTC
Sure, we can make it an enhancement request but I think that the current behavior is a bit unfortunate.

As for 2.24.1, that's what my gnome system monitor says and my repos are intrepid + ubuntu backports, so maybe it's because I'm using the backports. But anyway, I'm pretty sure that this bug was there even before using the backports.
Comment 10 Jens Granseuer 2008-11-27 20:04:17 UTC
2.24.1 is the version of gnome-system-monitor, then.

I've fixed directory cleanup in svn.

2008-11-27  Jens Granseuer  <...>
        
        * capplet-util.c: (directory_delete_recursive): don't try to delete
        the directory twice; fixes cleaning up after theme installations, for
        example (bug #562371)

Overwriting themes is a bit more involved and probably won't happen on the stable branch.
Comment 11 Bernhard Koenig 2008-11-28 08:26:57 UTC
OK, thanks a lot for the fix.

Btw, my Gnome is really 2.24.1, it says so in the system monitor and in "About Gnome" (in System --> About Gnome). Really!
Comment 12 Jens Granseuer 2008-11-28 13:42:41 UTC
(In reply to comment #11)
> Btw, my Gnome is really 2.24.1, it says so in the system monitor and in "About
> Gnome" (in System --> About Gnome). Really!

I don't doubt that, but Gnome consists of lots of packages, and the overall Gnome version is irrelevant in most cases. What matters are the individual package versions which you can get from your package manager or, for g-c-c, by running gnome-appearance-properties --version, for example.
Comment 13 Bernhard Koenig 2008-11-28 14:23:20 UTC
Aha, OK. Misunderstanding then, I thought you meant the GNOME version. My gnome-appearance-properties is indeed 2.24.0.1.
Comment 14 Jens Granseuer 2008-11-28 19:12:18 UTC
*** Bug 562587 has been marked as a duplicate of this bug. ***
Comment 15 Marco Tessarotto 2008-11-29 08:58:23 UTC
I think that should be marked as a bug and not as an enhancement.
I suppose that the manager could upgrade an icon theme, at least it should delete the theme directory (under .icons) and then reinstall it.

I think this is a bug because from gnome 2.24.1 every icon theme cannot be upgraded (reinstalled) without previously removing (manually) its directory under .icons

 
Comment 16 Jens Granseuer 2008-11-29 09:24:59 UTC
The problem that removing a theme does not properly remove the entire theme directory has already been fixed. The fix will be included in the next version.
Comment 17 Bastien Nocera 2011-03-17 15:00:11 UTC
Mass move to gnome-tweak-tool, for theme handling bugs.
Comment 18 Jeremy Bicha 2017-06-07 00:16:58 UTC
I'm closing this because it is not a Tweak Tool bug.