After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562204 - needlessly links against gmodule
needlessly links against gmodule
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Li Yuan
Li Yuan
Depends on:
Blocks:
 
 
Reported: 2008-11-25 08:07 UTC by Matthias Clasen
Modified: 2011-01-05 05:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.44 KB, patch)
2008-11-27 07:40 UTC, Li Yuan 		none Details | Review

Description Matthias Clasen 2008-11-25 08:07:26 UTC 
Why does atk link against gmodule ? I can't see any reason for that, and it yields the following: 

[mclasen@localhost devel]$ ldd -u -r /usr/lib/libatk-1.0.so
Unused direct dependencies:
	
	/lib/libgmodule-2.0.so.0
Comment 1 Li Yuan 2008-11-25 09:57:49 UTC 
The link is imported by the following line in configure.in:

if test "x$have_no_export" = "xtrue"; then
   GLIB_REQUIRED_VERSION=2.5.7
   glib_no_export_package="gmodule-no-export-2.0"

And the patch is from you at bug #158531 :)

I guess atk did depend on gmodule before, but not now.
Comment 2 Li Yuan 2008-11-27 07:40:50 UTC 
Created attachment 123525 [details] [review]
patch
Comment 3 Matthias Clasen 2008-11-28 01:59:00 UTC 
Looks fine to me.
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-01-02 00:28:48 UTC 
After review atk repository it seems that the patch was already applied.

Could anyone with the proper power close this bug?