After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562072 - Provide a screensaver from the user's cover art
Provide a screensaver from the user's cover art
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-23 23:43 UTC by Bastien Nocera
Modified: 2018-05-24 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for this bug (28.26 KB, patch)
2009-09-25 15:19 UTC, Maxim Ermilov
none Details | Review
Add cover art screensaver (29.41 KB, patch)
2010-04-06 15:26 UTC, Bastien Nocera
needs-work Details | Review
Add cover art screensaver (29.96 KB, patch)
2010-04-19 22:30 UTC, Maxim Ermilov
none Details | Review

Description Bastien Nocera 2008-11-23 23:43:39 UTC
Something like collage, but with coverart:
http://build.last.fm/item/455
Comment 1 Bastien Nocera 2008-12-11 15:00:44 UTC
Something like this:
http://www.youtube.com/watch?v=srDkugKfGY0
Could probably be done using Clutter, using Fluttr as a base (needs porting to Clutter 0.8):
http://git.clutter-project.org/cgit.cgi?url=toys/tree/fluttr
Comment 2 Sergey Rudchenko 2009-05-01 07:23:56 UTC
I'd like to implement the screensaver (using libclutter, indeed), but there are two architectural problems for me.

* Cover arts support is implemented as a plugin, so the screensaver has to be a part of the plugin (doh!).
* The artdisplay plugin is written in Python, so the cover search code sharing is problematic.

In order to solve the second problem, I'm starting to port the plugin to C. The artdisplay is very popular, it is enabled by default, so, I guess, it is worth to make it run as a native code. And, this would allow to share the cover searching code for the screensaver. Does this make sense? Does this have a chance to be committed?
Comment 3 Jonathan Matthew 2009-05-01 07:25:43 UTC
You can already request cover art for any database entry from another plugin.  The ipod and mtp plugins do this.  I don't really want to see the artdisplay plugin rewritten in C.
Comment 4 Maxim Ermilov 2009-09-25 15:19:27 UTC
Created attachment 144005 [details] [review]
Patch for this bug
Comment 5 Bastien Nocera 2010-04-06 15:26:41 UTC
Created attachment 158054 [details] [review]
Add cover art screensaver
Comment 6 Bastien Nocera 2010-04-06 15:33:43 UTC
Review of attachment 158054 [details] [review]:

A couple of comments:
- the configure changes should probably have a --enable-screensaver=XXX to force the screensaver to be built (and exit if requested but clutter was not present)
- the application itself uses an inordinate amount of memory, and took a long while to start up from cold (I would think up to 2 minutes), reading all 80GB of cover art I have
- the cover art floating above the cover grid was in the screen's aspect ratio, instead of being square.
Comment 7 Maxim Ermilov 2010-04-19 22:30:00 UTC
Created attachment 159114 [details] [review]
Add cover art screensaver
Comment 8 Bastien Nocera 2010-04-19 23:10:03 UTC
Maxim, could you explain what you changed in the latest patch?
Comment 9 Maxim Ermilov 2010-04-19 23:21:37 UTC
(In reply to comment #8)
> Maxim, could you explain what you changed in the latest patch?

I fix problems, that mentioned in review.
Comment 10 GNOME Infrastructure Team 2018-05-24 13:48:29 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/666.