After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561914 - Cover art is not transfered to DAP if folder depth is not set
Cover art is not transfered to DAP if folder depth is not set
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - USB Mass Storage
git master
Other Linux
: Normal normal
: 1.6
Assigned To: Gabriel Burt
Gabriel Burt
Depends on:
Blocks:
 
 
Reported: 2008-11-22 13:58 UTC by Bertrand Lorentz
Modified: 2009-01-21 20:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Handle unset folder depth correctly (3.45 KB, patch)
2008-11-22 14:00 UTC, Bertrand Lorentz 		committed Details | Review

Description Bertrand Lorentz 2008-11-22 13:58:46 UTC 
Cover art is not transfered to a DAP if it's folder depth is 0, which make sense. But this property defaults to 0 if it is not set through HAL or in the .is_audio_player file.

The HAL spec says "If the device does not have a limit, do not set this property".

The "folder depth" property should default to -1 if not set otherwise, and cover art should be transfered in this case.

I'll post a patch.
Comment 1 Bertrand Lorentz 2008-11-22 14:00:49 UTC 
Created attachment 123214 [details] [review]
Handle unset folder depth correctly

Make sure that "folder depth" defaults to -1 if it's not set, and transfer cover art to the DAP in this case.
Comment 2 Gabriel Burt 2009-01-13 20:53:04 UTC 
This looks good, commit after 1.4.2 please.
Comment 3 Bertrand Lorentz 2009-01-21 20:35:16 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.