After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561880 - Add a concept of "going modal" by grabbing the keyboard
Add a concept of "going modal" by grabbing the keyboard
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2008-11-22 00:43 UTC by Owen Taylor
Modified: 2008-12-03 22:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a concept of "going modal" by grabbing the keyboard (8.17 KB, patch)
2008-11-22 00:43 UTC, Owen Taylor
reviewed Details | Review

Description Owen Taylor 2008-11-22 00:43:29 UTC
This patch fixes problems where it was possible to click away from
the run dialog and focus some other window and still have the 
run dialog up but not getting keystrokes.

A remaining problem is that it is possible to Alt-Tab when the
overlay or the run dialog is up, and then Metacity ungrabs and
focuses an application widget; Some Metacity changes to disable
global key bindings temporarily may be needed, or there may
already be some functionality that can be exposed.

===
shell-global.[ch]: Replace shell_global_focus_stage()
  with shell_global_grab_keyboard()/shell_global_ungrab_keyboard()
main.js: Add startModal()/endModal() functions to go modal and
  undo that.
run_dialog.js overlay.js main.js: Use startModal() for the overlay
  and for the run dialog.
Comment 1 Owen Taylor 2008-11-22 00:43:32 UTC
Created attachment 123205 [details] [review]
Add a concept of "going modal" by grabbing the keyboard
Comment 2 Dan Winship 2008-11-24 15:42:54 UTC
seems ok
Comment 3 Owen Taylor 2008-12-03 22:00:57 UTC
Committed a long time ago.