After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561872 - Add a bg-color property to ShellTrayManager
Add a bg-color property to ShellTrayManager
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2008-11-21 23:19 UTC by Owen Taylor
Modified: 2008-12-03 22:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a bg-color property to ShellTrayManager (7.90 KB, patch)
2008-11-21 23:19 UTC, Owen Taylor 		reviewed Details | Review

Description Owen Taylor 2008-11-21 23:19:53 UTC 
shell_tray_manager.c: Add a bg-color property and implement it
 by setting a 1x1 pixmap of the right color as the background.

 Also, make the colormap of the tray manager window match that
 of the socket. That should (untested) make transparency work
 properly if the tray icon supports it.

panel.js: Set the bg-color property of the tray manager to
 match the panel.
Comment 1 Owen Taylor 2008-11-21 23:19:56 UTC 
Created attachment 123200 [details] [review]
Add a bg-color property to ShellTrayManager
Comment 2 Dan Winship 2008-11-24 15:51:54 UTC 
> +/* Sea Green - obnoxious to force people to set the background color */
> +static const ClutterColor default_color = { 0xbb, 0xff, 0xaa };

ha :)

> +  cairo_t *cr = gdk_cairo_create (pixmap);

Oof. Seems like you could use gdk_pixmap_create_from_data() or something... maybe it wouldn't turn out any simpler.


I haven't tried the patch to verify that it works, but I assume you were using it in the screenshots on your blog entry. (Or did you just change the panel bg color for that?) Anyway, if it works, it looks good.
Comment 3 Owen Taylor 2008-12-03 22:01:24 UTC 
Committed a while ago.