After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561734 - playbin2 additions
playbin2 additions
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-20 21:49 UTC by Michael Smith
Modified: 2008-11-24 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add API to playbin2 (12.35 KB, patch)
2008-11-20 21:50 UTC, Michael Smith 		reviewed Details | Review

Description Michael Smith 2008-11-20 21:49:16 UTC 
I'll attach a playbin2 patch that:
 - adds properties to control the buffer size/duration used for the queue2 element when in streaming mode
 - fires appropriate signals when a particular stream is selected
Comment 1 Michael Smith 2008-11-20 21:50:23 UTC 
Created attachment 123137 [details] [review]
Add API to playbin2

What do people think of this? Shall I land it?
Comment 2 Wim Taymans 2008-11-22 14:35:02 UTC 
seems good to me.
Comment 3 Tim-Philipp Müller 2008-11-24 20:02:32 UTC 
Two minor things:

 - gst_play_bin_get_{audio|video|text}_pad: do we really
   need the declarations three times? :)

 - get_current_stream_number(): I think

        if ((selector = gst_pad_get_parent (pad))) { .. }

   leaks a selector ref.
Comment 4 Michael Smith 2008-11-24 20:25:53 UTC 
Committed with suggested changes.