After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561733 - Merge sheet tabs and status area
Merge sheet tabs and status area
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-11-20 21:41 UTC by Morten Welinder
Modified: 2008-11-23 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (31.11 KB, patch)
2008-11-20 21:42 UTC, Morten Welinder
none Details | Review
Updated patch (39.81 KB, patch)
2008-11-21 22:01 UTC, Morten Welinder
none Details | Review
strange effect on tabs (9.03 KB, image/png)
2008-11-21 23:20 UTC, Andreas J. Guelzow
  Details
Updated patch (40.83 KB, patch)
2008-11-22 02:29 UTC, Morten Welinder
none Details | Review
Updated patch (43.20 KB, patch)
2008-11-22 21:55 UTC, Morten Welinder
committed Details | Review

Description Morten Welinder 2008-11-20 21:41:09 UTC
Patch coming up...
Comment 1 Morten Welinder 2008-11-20 21:42:08 UTC
Created attachment 123135 [details] [review]
Patch
Comment 2 Andreas J. Guelzow 2008-11-20 22:07:22 UTC
Index: samples/ttest.xls
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream


and what is this about?
Comment 3 Andreas J. Guelzow 2008-11-20 22:24:25 UTC
Well, when one adds 32 sheets (or whatever is necessary to run out of window space) then the last sheets are only accessible through t\he manage sheets dialog...  I don't think user will like that.
Comment 4 Morten Welinder 2008-11-20 23:59:51 UTC
> and what is this about?

A changed file in my tree.  And me being to lazy to edit the diff.

> Well, when one adds 32 sheets (or whatever is necessary to run out of window
> space) then the last sheets are only accessible through t\he manage sheets
> dialog...  I don't think user will like that.

Just change the creation of wbcg->bnotebook to...

	wbcg->bnotebook = g_object_new (GNM_NOTEBOOK_TYPE,
					"tab-pos", GTK_POS_BOTTOM,
					"show-border", FALSE,
					"tab-hborder", 0,
					"tab-vborder", 0,
					"scrollable", TRUE,
					NULL);

and you get arrows when space runs out.  Not very pretty ones in my theme,
but at least functional.
Comment 5 Morten Welinder 2008-11-21 22:01:06 UTC
Created attachment 123198 [details] [review]
Updated patch

This one behaves a bit better.
Comment 6 Andreas J. Guelzow 2008-11-21 23:18:14 UTC
This is defintiely much better but there is a strange effect if you drag the separator to the right beyond the window and then back a little bit into the window again.
Comment 7 Andreas J. Guelzow 2008-11-21 23:20:09 UTC
Created attachment 123201 [details]
strange effect on tabs
Comment 8 Morten Welinder 2008-11-22 02:29:10 UTC
Created attachment 123206 [details] [review]
Updated patch

1. Don't allow going too far to the right.
2. Don't allow going too far to the left.
3. Double click the slider to unset the fixed position.
Comment 9 Morten Welinder 2008-11-22 21:55:21 UTC
Created attachment 123243 [details] [review]
Updated patch

Patch updated to match current HEAD.
Comment 10 Morten Welinder 2008-11-23 15:21:44 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.